Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/1] package/xscreensaver: fix linking with intl
Date: Wed, 27 Aug 2014 23:52:58 +0200	[thread overview]
Message-ID: <53FE533A.1040502@openwide.fr> (raw)

Hi Thomas,

Le 26/08/2014 09:23, Thomas Petazzoni a ?crit :
> Dear Romain Naour,
> 
> On Tue, 26 Aug 2014 01:13:06 +0200, Romain Naour wrote:
> 
>> +	select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT
> 
> Have you verified if it's really BR2_NEEDS_GETTEXT or
> BR2_NEEDS_GETTEXT_IF_LOCALE that should be used?
> 

gettext package is always selected with xscreensaver when BR2_NEEDS_GETTEXT is
set due to dependencies on libgtk2 and libglib2.

This is libglib2 that select gettext package when BR2_NEEDS_GETTEXT is set.

But, It seems that xscreensaver can live without gettext by looking at
utils/xscreensaver-intl.h.

So, it's seems correct to select gettext package when
BR2_NEEDS_GETTEXT_IF_LOCALE is set but the build fail with the following link error:

xscreensaver.o: In function `main':
undefined reference to `libintl_bindtextdomain'
undefined reference to `libintl_textdomain'

That why I added BR2_NEEDS_GETTEXT...

Ok, I just found a patch that fix this issue in version 5.28.
Please see v3.

Thanks for your review !

Best regards
Romain

             reply	other threads:[~2014-08-27 21:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-27 21:52 Romain Naour [this message]
  -- strict thread matches above, loose matches on Subject: below --
2014-08-25 23:13 [Buildroot] [PATCH v2 1/1] package/xscreensaver: fix linking with intl Romain Naour
2014-08-26  7:23 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FE533A.1040502@openwide.fr \
    --to=romain.naour@openwide.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox