Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/3] package/libinput: fix build with libevdev
Date: Thu, 28 Aug 2014 23:31:42 +0200	[thread overview]
Message-ID: <53FF9FBE.9020605@openwide.fr> (raw)
In-Reply-To: <53FC4FCA.3030307@imgtec.com>

Hi Vicente,

Le 26/08/2014 11:13, Vicente Olivert Riera a ?crit :
> On 08/25/2014 10:01 PM, Romain Naour wrote:
>> Hi Thomas,
>>
>> Le 25/08/2014 20:12, Thomas Petazzoni a ?crit :
>>> Dear Romain Naour,
>>>
>>> On Sun, 24 Aug 2014 18:53:05 +0200, Romain Naour wrote:
>>>> libevdev and libinput use the same function name (log_msg).
>>>> An easy fix is to rename one of the two functions.
>>>>
>>>> Fixes:
>>>> http://autobuild.buildroot.net/results/b1e/b1ea94f09d6f7459e3d7794c4a62bbdbb53d5da6/build-end.log
>>>>
>>>>
>>>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>>>> ---
>>>>   ...put-01-rename-log_msg-to-libinput_log_msg.patch | 58
>>>> ++++++++++++++++++++++
>>>>   1 file changed, 58 insertions(+)
>>>>   create mode 100644
>>>> package/libinput/libinput-01-rename-log_msg-to-libinput_log_msg.patch
>>>
>>> Committed, but please submit upstream.
>>>
>>
>> I'll do.
>>
>> Best regards,
>> Romain
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>>
> 
> Some changes to fix this kind of issues have been applied upstream. Please have
> a look to:
> 
> https://bugs.freedesktop.org/show_bug.cgi?id=82292

Thanks for the link !

I should have looked at the latest commits...

> 
> Maybe it's worth to do a version bump and check if that new patch is no longer
> necessary.
> 

Yes, I reverted my commit and I built libinput-0.3.0 using a backported version
of this patch:
http://lists.freedesktop.org/archives/wayland-devel/2014-August/016599.html

Also, libevdev has renamed the functions log_msg to _libevdev_log_msg.
So, the issue will be fixed without my patch in the next version bump of
libevdev or libinput.

Best regards,
Romain

  reply	other threads:[~2014-08-28 21:31 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-24 16:53 [Buildroot] [PATCH 1/3] package/libevas-generic-loaders: needs zlib Romain Naour
2014-08-24 16:53 ` [Buildroot] [PATCH 2/3] package/libinput: fix build with libevdev Romain Naour
2014-08-25 18:12   ` Thomas Petazzoni
2014-08-25 21:01     ` Romain Naour
2014-08-26  9:13       ` Vicente Olivert Riera
2014-08-28 21:31         ` Romain Naour [this message]
2014-08-24 16:53 ` [Buildroot] [PATCH 3/3] package/libarchive: fix linking issue with uClibc Romain Naour
2014-08-25 21:03   ` Thomas Petazzoni
2014-08-28 21:50     ` Romain Naour
2014-08-25 18:08 ` [Buildroot] [PATCH 1/3] package/libevas-generic-loaders: needs zlib Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=53FF9FBE.9020605@openwide.fr \
    --to=romain.naour@openwide.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox