From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas De Schampheleire Date: Mon, 16 Dec 2013 17:39:02 +0100 Subject: [Buildroot] [PATCH 1/1] smcroute: new package In-Reply-To: References: <1386872059-28046-1-git-send-email-mlweber1@rockwellcollins.com> <3a2395ee-73bc-4723-a368-61194e9c0a08@email.android.com> Message-ID: <53f6441d-e221-4316-a6bb-ca80be307cae@email.android.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net mlweber1 at rockwellcollins.com wrote: >Thomas De Schampheleire wrote on 12/16/2013 >09:25:41 AM: > >> From: Thomas De Schampheleire >> To: mlweber1 at rockwellcollins.com >> Cc: buildroot , Sean Gerhardt >> >> Date: 12/16/2013 09:25 AM >> Subject: Re: [Buildroot] [PATCH 1/1] smcroute: new package >> >> Hi Matt, >> >> On Mon, Dec 16, 2013 at 3:07 PM, wrote: >> >> >> >+SMCROUTE_SITE = $(call >github,troglobit,smcroute,$(SMCROUTE_VERSION)) >> >> >+SMCROUTE_SOURCE = >> > troglobit-smcroute-$(SMCROUTE_VERSION)-0-g58388f6.tar.gz >> >> >> >> Why is it needed to specify _SOURCE here? It shouldn't be .. >> > It seems like the releases are labeled in a way that requires this. >> > Without >> > specifying the source archive name, the archive that's requested to be >> > downloaded >> > "smcroute-$(SMCROUTE_VERSION).tar.gz" ends up as the file we noted as >the >> > SOURCE. >> >> I'm not sure I understand what you mean. >> When I remove the _SOURCE line, I can still download and extract the >> package normally. The name of the tar file is indeed different, but >> this does not matter. The package infrastructure still correctly >> handles it. >> >> If you still think this _SOURCE is needed, could you explain in more >detail? > >I think I figured out what's happening. (Our office firewall makes this >almost impossible to test, so I'll have to confirm tonight) >If I remove the SOURCE archive definition from the .mk, the package >downloads and I think the buildroot pkg scripts then use the >resulting filename of the archive to extract it, which results in the >correct smcroute folder under build. I think the issue with not defining >the >SOURCE filename comes into play if a buildroot dl cached local archive >file is >used to build the package. Buildroot then can't find the source archive >because the cached archive file has a unique filename. This results in >the buildroot pkg scripts proceeding to re-download the source archive >again before continuing with extracting the unique filename and doing >proceeding with the rest of the pkg build. > >We noticed this because our builds primarily using a cached/mirrored dl >folder of archive files. But this should be fixed by adding the new file to your dl cache right?