From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] setserial: Disable manpages
Date: Thu, 4 Sep 2014 16:24:18 +0100 [thread overview]
Message-ID: <54088422.8060507@imgtec.com> (raw)
In-Reply-To: <87a96fs96p.fsf@dell.be.48ers.dk>
On 09/04/2014 04:21 PM, Peter Korsgaard wrote:
>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
>
> > There is no configure option to disable the manpages, so we use this
> > patch to disable them. Otherwise this package would fail to build on
> > systems without the groff package installed because the build system
> > calls 'nroff' in the Makefile.
>
> > Fixes:
> > http://autobuild.buildroot.net/results/c73/c736933d4110865008f2d1e8b531b6e392c68285/
>
> > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> > Reviewed-by: Markos Chandras <Markos.Chandras@imgtec.com>
> > ---
> > .../setserial-0003-disable-manpages.patch | 61 ++++++++++++++++++++
> > 1 files changed, 61 insertions(+), 0 deletions(-)
> > create mode 100644 package/setserial/setserial-0003-disable-manpages.patch
>
> > diff --git a/package/setserial/setserial-0003-disable-manpages.patch b/package/setserial/setserial-0003-disable-manpages.patch
> > new file mode 100644
> > index 0000000..ebd3cb2
> > --- /dev/null
> > +++ b/package/setserial/setserial-0003-disable-manpages.patch
> > @@ -0,0 +1,61 @@
> > +setserial: Disable manpages
> > +
> > +There is no configure option to disable the manpages, so we use this
> > +patch to disable them. Otherwise this package would fail to build on
> > +systems without the groff package installed because the build system
> > +calls 'nroff' in the Makefile.
>
> Nit: All these lines have a trailing space.
>
> > +
> > +Fixes:
> > + http://autobuild.buildroot.net/results/c73/c736933d4110865008f2d1e8b531b6e392c68285/
> > +
> > +Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
> > +--- setserial-2.17/Makefile.in.orig 2014-09-04 11:58:05.685475241 +0100
> > ++++ setserial-2.17/Makefile.in 2014-09-04 11:59:14.508641155 +0100
> > +@@ -17,26 +17,20 @@ DEFS = @DEFS@
> > + INCS = -I.
> > + TAR = tar
> > +
> > +-all: setserial setserial.cat
> > ++all: setserial
>
> As far as I can see, nroff is only used for setserial.cat, and
> setserial.cat is not installed / used anywhere, so just patching this
> line is enough and the rest of the patch can get dropped.
Don't you prefer to completely get rid of the manual pages?
--
Vincent
next prev parent reply other threads:[~2014-09-04 15:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-04 11:18 [Buildroot] [PATCH 1/2] setserial: Rename patches to add sequence numbers Vicente Olivert Riera
2014-09-04 11:18 ` [Buildroot] [PATCH 2/2] setserial: Disable manpages Vicente Olivert Riera
2014-09-04 15:21 ` Peter Korsgaard
2014-09-04 15:24 ` Vicente Olivert Riera [this message]
2014-09-04 20:39 ` Peter Korsgaard
2014-09-04 15:21 ` [Buildroot] [PATCH 1/2] setserial: Rename patches to add sequence numbers Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54088422.8060507@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox