From: "Jörg Krause" <jkrause@posteo.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/upmpdcli: Fix build with uclibc on SH4
Date: Thu, 02 Oct 2014 14:25:21 +0200 [thread overview]
Message-ID: <542D4431.3070600@posteo.de> (raw)
In-Reply-To: <20141001231851.325e4460@free-electrons.com>
Dear Thomas,
On 10/01/2014 11:18 PM, Thomas Petazzoni wrote:
> Dear J?rg Krause,
>
> On Wed, 1 Oct 2014 23:00:56 +0200, J?rg Krause wrote:
>> Add missing header file <cstdio> to the uclibc patch to fix build with target SH4.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/e5be8fe46a30f0b417fe5fc19a27c480d885791e/
>> http://autobuild.buildroot.net/results/a3453afddff4fc03681f7fbdff3ccab9706eb189/
>>
>> Signed-off-by: J?rg Krause <jkrause@posteo.de>
> Do you know why the issue is SH4 specific? Is it because our SH4
> toolchains are very old compared to the other Buildroot toolchains (due
> to the SH4 support being broken in the internal toolchain backend) ?
I don't know. The SH4 toolchain is not so old, it's gcc 4.7.3. I guess
it has something to do with the ability or strictness of the compiler to
dissolve header dependencies. But I'm not a toolchain expert...
We will use the tool "include-what-you-use" from google to fix missing
header issues for upmpdcli.
Best regards
J?rg
prev parent reply other threads:[~2014-10-02 12:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 21:00 [Buildroot] [PATCH 1/1] package/upmpdcli: Fix build with uclibc on SH4 Jörg Krause
2014-10-01 21:18 ` Thomas Petazzoni
2014-10-02 12:25 ` Jörg Krause [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542D4431.3070600@posteo.de \
--to=jkrause@posteo.de \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).