From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] automake: update gtk-doc.m4 to serial 2
Date: Fri, 10 Oct 2014 10:50:26 -0300 [thread overview]
Message-ID: <5437E422.5030502@zacarias.com.ar> (raw)
In-Reply-To: <20141010152856.19129c7c@free-electrons.com>
On 10/10/2014 10:28 AM, Thomas Petazzoni wrote:
> Come on Gustavo, no need to start being aggressive here.
Huh? It's not intended to be aggressive.
> Yes, that's exactly what I suggest. And actually, we already need to
> add host-pkgconf in DEPENDENCIES when doing autoreconf, if the
> configure.ac uses PKG_CHECK_MODULES, which is far more common than
> packages using gtk-doc.m4 specifically.
>
> PKG_CHECK_MODULES in configure.ac requiring host-pkgconf in the
> DEPENDENCIES is precisely the reason why I proposed
> http://patchwork.ozlabs.org/patch/340902/ some time ago. Nothing
> prevents from adding a similar check to see if the package uses
> the gtk-doc.m4 macros or not. That would at least warn loudly if such
> macros are used without the package having host-pkgconf in its
> dependencies.
Well, at least from my POV it's making some packages need host-pkgconf
just because they use gtk-doc.m4, we're bumping the version and they're
AUTORECONFed. If they weren't AUTORECONFed they maybe didn't need
host-pkgconf (maybe for other purposes, but not because of the old
gtk-doc.m4) so it seems to me it's autotools/autoreconfs fault, and it
should be handled there.
It has nothing to do with packages that don't account for host-pkgconf
usage without accounting for it in the first place.
Regards.
next prev parent reply other threads:[~2014-10-10 13:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-10 10:28 [Buildroot] [PATCH 1/2] automake: update gtk-doc.m4 to serial 2 Gustavo Zacarias
2014-10-10 10:28 ` [Buildroot] [PATCH 2/2] kmod: needs to autoreconf Gustavo Zacarias
2014-10-10 10:36 ` Vicente Olivert Riera
2014-10-12 9:07 ` Peter Korsgaard
2014-10-10 10:35 ` [Buildroot] [PATCH 1/2] automake: update gtk-doc.m4 to serial 2 Vicente Olivert Riera
2014-10-10 10:41 ` Thomas Petazzoni
2014-10-10 10:45 ` Gustavo Zacarias
2014-10-10 11:01 ` Thomas Petazzoni
2014-10-10 11:12 ` Gustavo Zacarias
2014-10-10 13:28 ` Thomas Petazzoni
2014-10-10 13:50 ` Gustavo Zacarias [this message]
2014-10-12 9:07 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5437E422.5030502@zacarias.com.ar \
--to=gustavo@zacarias.com.ar \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox