From: "Jörg Krause" <jkrause@posteo.de>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/mpd: bump to version 0.19
Date: Mon, 13 Oct 2014 09:43:52 +0200 [thread overview]
Message-ID: <543B82B8.1040207@posteo.de> (raw)
In-Reply-To: <20141012214016.04260709@free-electrons.com>
Dear Thomas Petazzoni,
On 10/12/2014 09:40 PM, Thomas Petazzoni wrote:
> Dear J?rg Krause,
>
> On Sun, 12 Oct 2014 21:10:57 +0200, J?rg Krause wrote:
>
>> diff --git a/package/mpd/Config.in b/package/mpd/Config.in
>> index 8884464..c4a263a 100644
>> --- a/package/mpd/Config.in
>> +++ b/package/mpd/Config.in
>> @@ -1,12 +1,14 @@
>> menuconfig BR2_PACKAGE_MPD
>> bool "mpd"
>> + depends on BR2_LARGEFILE # boost
> Then the comment at the bottom of mpd's Config.in should be updated as
> well.
>
Done.
>> +config BR2_PACKAGE_MPD_ICU
>> + bool "icu"
> "icu support", or "Unicode support"
Done.
>> + default y
> Any reason to enable it by default?
Unicode support is enabled by default in mpd configure. It has to be
disabled by the user. I just wanted to be consistent in the sense of the
mpd configure file.
>> diff --git a/package/mpd/mpd.mk b/package/mpd/mpd.mk
>> index 932df08..b98043d 100644
>> --- a/package/mpd/mpd.mk
>> +++ b/package/mpd/mpd.mk
>> @@ -4,11 +4,11 @@
>> #
>> ################################################################################
>>
>> -MPD_VERSION_MAJOR = 0.18
>> -MPD_VERSION = $(MPD_VERSION_MAJOR).16
>> +MPD_VERSION_MAJOR = 0.19
>> +MPD_VERSION = $(MPD_VERSION_MAJOR)
> The MPD_VERSION_MAJOR variable becomes a bit useless, but ok, we can
> believe that they will do some 0.19.x release in the future.
Yeah, I think so, too.
>
>> MPD_SOURCE = mpd-$(MPD_VERSION).tar.xz
>> MPD_SITE = http://www.musicpd.org/download/mpd/$(MPD_VERSION_MAJOR)
>> -MPD_DEPENDENCIES = host-pkgconf libglib2
>> +MPD_DEPENDENCIES = host-pkgconf boost libglib2
>> MPD_LICENSE = GPLv2+
>> MPD_LICENSE_FILES = COPYING
>>
>> @@ -175,6 +175,13 @@ else
>> MPD_CONF_OPTS += --disable-ffmpeg
>> endif
>>
>> +# icu is enabled by default
>> +ifeq ($(BR2_PACKAGE_MPD_ICU),y)
>> +MPD_DEPENDENCIES += icu
> MPD_CONF_OPTS += --enable-icu
As described above, icu (unicode support) is enabled by default. But I
will add this.
>
>> +else
>> +MPD_CONF_OPTS += --disable-icu
>> +endif
>> +
>> define MPD_INSTALL_EXTRA_FILES
>> @if [ ! -f $(TARGET_DIR)/etc/mpd.conf ]; then \
>> $(INSTALL) -D package/mpd/mpd.conf \
Many thanks for the review!
J?rg
next prev parent reply other threads:[~2014-10-13 7:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-12 19:10 [Buildroot] [PATCH 1/1] package/mpd: bump to version 0.19 Jörg Krause
2014-10-12 19:40 ` Thomas Petazzoni
2014-10-13 7:43 ` Jörg Krause [this message]
2014-10-14 7:41 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543B82B8.1040207@posteo.de \
--to=jkrause@posteo.de \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox