From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1 v3] ubus: new package
Date: Tue, 14 Oct 2014 23:33:07 +0200 [thread overview]
Message-ID: <543D9693.5070609@mind.be> (raw)
In-Reply-To: <1413280007-16819-1-git-send-email-swexru@gmail.com>
On 14/10/14 11:46, Alexey Mednyy wrote:
> Signed-off-by: Alexey Mednyy <swexru@gmail.com>
> ---
> package/Config.in | 1 +
> package/ubus/Config.in | 14 +++++++++++++
> package/ubus/ubus-01-json-definition-fix.patch | 27 +++++++++++++++++++++++++
> package/ubus/ubus.mk | 28 ++++++++++++++++++++++++++
> 4 files changed, 70 insertions(+)
> create mode 100644 package/ubus/Config.in
> create mode 100644 package/ubus/ubus-01-json-definition-fix.patch
> create mode 100644 package/ubus/ubus.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 19bb9bf..16d4901 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -896,6 +896,7 @@ menu "Other"
> source "package/startup-notification/Config.in"
> source "package/tz/Config.in"
> source "package/tzdata/Config.in"
> + source "package/ubus/Config.in"
> endmenu
>
> menu "Security"
> diff --git a/package/ubus/Config.in b/package/ubus/Config.in
> new file mode 100644
> index 0000000..b0f5de9
> --- /dev/null
> +++ b/package/ubus/Config.in
> @@ -0,0 +1,14 @@
> +config BR2_PACKAGE_UBUS
> + bool "ubus"
> + select BR2_PACKAGE_LIBUBOX
> + select BR2_PACKAGE_JSON_C
> + depends on !BR2_PREFER_STATIC_LIB
> + help
> + OpenWrt micro bus architecture, project
> + provide communication between various
> + daemons and applications.
> +
> + http://wiki.openwrt.org/doc/techref/ubus
> +
> +comment "ubus needs toolchain w/ dynamic library"
> + depends on BR2_PREFER_STATIC_LIB
> diff --git a/package/ubus/ubus-01-json-definition-fix.patch b/package/ubus/ubus-01-json-definition-fix.patch
> new file mode 100644
> index 0000000..50f9096
> --- /dev/null
> +++ b/package/ubus/ubus-01-json-definition-fix.patch
> @@ -0,0 +1,27 @@
In addition to Samuel's comments, a path should have a description and a
Signed-off-by line, just like if it was an actual commit (see [1]). We would
anyway like you to upstream this patch to OpenWRT, so you'll need that commit
message and SoB there anyway.
> +diff --git a/CMakeLists.txt b/CMakeLists.txt
> +index cb2f420..86c4c4d 100644
> +--- a/CMakeLists.txt
> ++++ b/CMakeLists.txt
[snip]
Regards,
Arnout
[1]
http://nightly.buildroot.org/manual.html#_format_and_licensing_of_the_package_patches
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
prev parent reply other threads:[~2014-10-14 21:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 9:46 [Buildroot] [PATCH 1/1 v3] ubus: new package Alexey Mednyy
2014-10-14 19:22 ` Samuel Martin
2014-10-15 12:05 ` Alexey Mednyy
2014-10-15 12:08 ` Samuel Martin
2014-10-14 21:33 ` Arnout Vandecappelle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543D9693.5070609@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox