Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] partclone package issues
Date: Wed, 15 Oct 2014 19:26:00 +0200	[thread overview]
Message-ID: <543EAE28.8080903@mind.be> (raw)
In-Reply-To: <CABDNR17qm+njSsYRcyzvSPy3c9yyrXGH_Y66_KwOOKAgWbqa2A@mail.gmail.com>

On 10/10/14 21:46, Michael Sumulong wrote:
[snip]
> partclone-0.2.70/configure.ac <http://configure.ac>:
> 
> if test "$enable_extfs" = "yes"; then
> #check library of some filesystems
> dnl Check for EXT2/3
> AC_CHECKING([ for EXT2/3 Library and Header files ... ])
> AC_CHECK_HEADERS([ext2fs/ext2fs.h], ,
>   AC_MSG_ERROR([*** EXT2/3 header files (ext2fs/ext2fs.h) not found])
> )
> AC_CHECK_LIB([ext2fs], [ext2fs_initialize], true,
>     AC_MSG_ERROR([*** EXT2/3 library (libext2fs) not found]))
> 
> AC_MSG_CHECKING(version of libextfs)
> extfs_version=`$cc $srcdir/src/deplib_version.c -o $srcdir/get_lib_version
> -lext2fs -DEXTFS`
> extfs_version=`$srcdir/get_lib_version extfs`

 This thing is clearly not cross-compile friendly. You'll have to add a patch
that replaces all this rubbish with something using PKG_CHECK_MODULES. It should
actually also update CFLAGS and LDFLAGS according the pkg-config results, so it
won't be completely trivial. But you should be able to replace about 20 lines of
configure.ac with just 4 lines using PKG_CHECK_MODULES.

 Preferably, you should also upstream that patch to introduce PKG_CHECK_MODULES,
so we don't have to carry that patch forever.


 Regards,
 Arnout

> 
> 
> partclone.mk <http://partclone.mk>:
> 
> PARTCLONE_VERSION = 0.2.70
> PARTCLONE_SOURCE = partclone-$(PARTCLONE_VERSION).tar.gz
> PARTCLONE_SITE = http://sourceforge.net/projects/partclone/files/testing/src/
> PARTCLONE_INSTALL_STAGING = YES
> PARTCLONE_INSTALL_TARGET = YES
> PARTCLONE_AUTORECONF = YES
> PARTCLONE_DEPENDENCIES = attr e2fsprogs libgcrypt lzo xz zlib
> PARTCLONE_CONF_OPT = --enable-ntfs --enable-extfs --enable-fat --enable-ncursesw
> 
> $(eval $(autotools-package))
> 
> 
> Thanks,
> Mike
> 
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

      parent reply	other threads:[~2014-10-15 17:26 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-10 19:46 [Buildroot] partclone package issues Michael Sumulong
2014-10-11 21:24 ` Thomas Petazzoni
2014-10-15 17:26 ` Arnout Vandecappelle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=543EAE28.8080903@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox