From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?SsO2cmcgS3JhdXNl?= Date: Thu, 16 Oct 2014 12:29:29 +0200 Subject: [Buildroot] [PATCH v2 4/8] package/mpd: enable support for libsoxr In-Reply-To: <20141016113337.439d3720@free-electrons.com> References: <1413379134-28918-1-git-send-email-jkrause@posteo.de> <1413379134-28918-4-git-send-email-jkrause@posteo.de> <20141016113337.439d3720@free-electrons.com> Message-ID: <543F9E09.1020105@posteo.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Thomas Petazzoni, On 10/16/2014 11:33 AM, Thomas Petazzoni wrote: > Dear J?rg Krause, > > On Wed, 15 Oct 2014 15:18:50 +0200, J?rg Krause wrote: >> Signed-off-by: J?rg Krause >> --- >> Changes v1 -> v2: >> - none >> --- >> package/mpd/Config.in | 7 +++++++ >> package/mpd/mpd.mk | 7 +++++++ >> 2 files changed, 14 insertions(+) >> >> diff --git a/package/mpd/Config.in b/package/mpd/Config.in >> index 10f3cf0..eba280a 100644 >> --- a/package/mpd/Config.in >> +++ b/package/mpd/Config.in >> @@ -46,6 +46,13 @@ config BR2_PACKAGE_MPD_LIBSAMPLERATE >> Enable libsamplerate input support. >> Select this for software sample rate conversion. >> >> +config BR2_PACKAGE_MPD_LIBSOXR >> + bool "libsoxr" >> + select BR2_PACKAGE_LIBSOXR >> + help >> + Enable libsoxr resampler support. >> + The SoX Resampler library performs software sample-rate conversion. >> + > I apologize for the silly comment, but the indentation is wrong here. > The help text should be indented with one tab plus two spaces, not two > tabs. > > Same issue applies to patches 4, 5, 6 and 7 of your series. Don't apologize, every comment is very welcome! Yes, the intendation is wrong for almost all existing help texts in mpd. I will fix the submitted patches and add an additional one to fix the intendation of the existing help texts. -------------- next part -------------- An HTML attachment was scrubbed... URL: