Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] package/pkg-autotools.mk: set --localstatedir=/var by default
Date: Sat, 18 Oct 2014 15:03:09 +0200	[thread overview]
Message-ID: <5442650D.1010207@mind.be> (raw)
In-Reply-To: <1413585393-8349-1-git-send-email-jkrause@posteo.de>

On 18/10/14 00:36, J?rg Krause wrote:
> `localstatedir` is a common autoconf variable like prefix and sysconfdir. At 
> this time 25 autotools and one generic package uses this Makefile variable. 22 
> of the autotools packages use --localstatedir=/var, the remaining use custom 
> settings.
> 
> Setting `localstatedir` to /var is consistent with the Filesystem Hierarchy 
> Standard (FHS). So it's time to move it as a common definition in the 
> autotools infrastructure. 
> 
> Signed-off-by: J?rg Krause <jkrause@posteo.de>

Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>


 Regards,
 Arnout

> ---
>  package/pkg-autotools.mk | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/pkg-autotools.mk b/package/pkg-autotools.mk
> index 2c93dd9..3c5430f 100644
> --- a/package/pkg-autotools.mk
> +++ b/package/pkg-autotools.mk
> @@ -134,6 +134,7 @@ define $(2)_CONFIGURE_CMDS
>  		--prefix=/usr \
>  		--exec-prefix=/usr \
>  		--sysconfdir=/etc \
> +		--localstatedir=/var \
>  		--program-prefix="" \
>  		--disable-gtk-doc \
>  		--disable-doc \
> @@ -165,6 +166,7 @@ define $(2)_CONFIGURE_CMDS
>  		./configure \
>  		--prefix="$$(HOST_DIR)/usr" \
>  		--sysconfdir="$$(HOST_DIR)/etc" \
> +		--localstatedir="$$(HOST_DIR)/var" \
>  		--enable-shared --disable-static \
>  		--disable-gtk-doc \
>  		--disable-doc \
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  parent reply	other threads:[~2014-10-18 13:03 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-17 22:36 [Buildroot] [PATCH 1/2] package/pkg-autotools.mk: set --localstatedir=/var by default Jörg Krause
2014-10-17 22:36 ` [Buildroot] [PATCH 2/2] package/.mk files: remove --localstatedir=/var from autotools packages Jörg Krause
2014-10-18 13:03   ` Arnout Vandecappelle
2014-10-19  9:37   ` Thomas Petazzoni
2014-10-18 13:03 ` Arnout Vandecappelle [this message]
2014-10-19  9:36 ` [Buildroot] [PATCH 1/2] package/pkg-autotools.mk: set --localstatedir=/var by default Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5442650D.1010207@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox