From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] xtables-addons: new package
Date: Thu, 23 Oct 2014 08:07:52 -0300 [thread overview]
Message-ID: <5448E188.8010408@zacarias.com.ar> (raw)
In-Reply-To: <5447E6E5.10904@mind.be>
On 10/22/2014 02:18 PM, Arnout Vandecappelle wrote:
>> +define XTABLES_ADDONS_BUILD_CMDS
>> + $(MAKE) -C $(@D) $(LINUX_MAKE_FLAGS)
>
> Is there a reason why
>
> XTABLE_ADDONS_MAKE_OPTS = $(LINUX_MAKE_FLAGS)
>
> doesn't work instead of overriding the build commands?
>
> Regards,
> Arnout
>
>> +endef
>> +
>> +define XTABLES_ADDONS_INSTALL_TARGET_CMDS
>> + $(MAKE) -C $(@D) $(LINUX_MAKE_FLAGS) DESTDIR="$(TARGET_DIR)" install
>> +endef
It works for build but not for install, i can send a v2 just dropping
the build cmds and adding the opts.
Regarding the comment, there are packages that do so, for example fmc
and fmlib.
There are other packages that depend on linux as well but don't
have/need separate comment entries - being dependant on a kernel being
built i suspect some may need extra toolchain options but they aren't
audited by autobuilds hence they're not taken care of.
Regards.
next prev parent reply other threads:[~2014-10-23 11:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-21 21:10 [Buildroot] [PATCH 1/3] xtables-addons: new package Gustavo Zacarias
2014-10-21 21:10 ` [Buildroot] [PATCH 2/3] iptables: enable basic kernel options Gustavo Zacarias
2014-10-28 18:02 ` Thomas Petazzoni
2014-10-28 18:04 ` Gustavo Zacarias
2014-10-28 18:10 ` Thomas Petazzoni
2014-10-28 22:11 ` Arnout Vandecappelle
2014-10-21 21:10 ` [Buildroot] [PATCH 3/3] xtables-addons: enable necessary " Gustavo Zacarias
2014-10-22 17:18 ` [Buildroot] [PATCH 1/3] xtables-addons: new package Arnout Vandecappelle
2014-10-22 22:38 ` Gustavo Zacarias
2014-10-28 22:18 ` Arnout Vandecappelle
2014-10-23 11:07 ` Gustavo Zacarias [this message]
2015-01-10 17:55 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5448E188.8010408@zacarias.com.ar \
--to=gustavo@zacarias.com.ar \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox