From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] kmod: bump to version 19
Date: Tue, 18 Nov 2014 13:26:47 +0000 [thread overview]
Message-ID: <546B4917.30706@imgtec.com> (raw)
In-Reply-To: <20141118142123.47e08033@free-electrons.com>
Dear Thomas Petazzoni,
On 11/18/2014 01:21 PM, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
>
> On Mon, 17 Nov 2014 16:59:36 +0000, Vicente Olivert Riera wrote:
>> - Bump to version 19
>> - Rename 0001 patch to follow the new name convention
>> - Adapt the 0001 patch to the new version
>> - Remove the already-upstreamed 0002 patch
>> - Update the hash value
>>
>> Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>
> Applied to next, thanks. After changing just one thing.
>
>> diff --git a/package/kmod/kmod-0001-fix-O_CLOEXEC.patch b/package/kmod/0001-fix-O_CLOEXEC.patch
>> similarity index 83%
>> rename from package/kmod/kmod-0001-fix-O_CLOEXEC.patch
>> rename to package/kmod/0001-fix-O_CLOEXEC.patch
>> index 4861c57..e09372c 100644
>> --- a/package/kmod/kmod-0001-fix-O_CLOEXEC.patch
>> +++ b/package/kmod/0001-fix-O_CLOEXEC.patch
>> @@ -1,3 +1,7 @@
>> +Adapt this patch to version 19
>> +
>> +Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
>
> I don't think this should go here, otherwise the patch isn't a proper
> git patch anymore. Instead, I modified the commit log to add the fact
> that you updated the patch to version 19, and added your SoB below
> Thomas DS one.
>
> See:
> http://git.buildroot.net/buildroot/tree/package/kmod/0001-fix-O_CLOEXEC.patch?h=next.
yes, I agree that's better. Thank you Thomas, I will do it in that way
from now on :-)
Cheers,
--
Vicente Olivert Riera
Graduate Software Engineer, MIPS Processor IP
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com
prev parent reply other threads:[~2014-11-18 13:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 16:59 [Buildroot] [PATCH] kmod: bump to version 19 Vicente Olivert Riera
2014-11-18 13:21 ` Thomas Petazzoni
2014-11-18 13:26 ` Vicente Olivert Riera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546B4917.30706@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox