Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH RFC] Makefile: from a defconfig file, point to the corresponding board/ entry
Date: Thu, 27 Nov 2014 07:41:53 -0300	[thread overview]
Message-ID: <5476FFF1.8090304@zacarias.com.ar> (raw)
In-Reply-To: <CAAXf6LU7cF0+R=7T6RE4M3efW52a1v+JyqkjgOEJ3ZXsV+dm8g@mail.gmail.com>

On 11/27/2014 07:37 AM, Thomas De Schampheleire wrote:

>> So, we could maybe improve this by renaming and moving our boards docs
>> so there is a one-to-one mapping from the board directory to the
>> corresponding defconfig file (but not necessarily the other way around).
> 
> 
> I would like to point out that automatically detecting the board
> directory is fragile, because
> - the mapping may not be obvious, as you already found
> - there may be more than one 'board' directory. For example, a typical
> setup when having multiple more-or-less-related projects in a company
> is to have several layers of post-build/rootfs-overlay/..., for
> example:
> board/company/common/...
> board/company/project1/...
> board/company/project2/...
> In the defconfigs of both project1 and project2, the post-build and
> rootfs-overlay settings would contain multiple entries, being
> common+project1 and common+project2 respectively.
> There may even be more levels than that, for example (in my case)
> common, architecture-specific, project-family-specific,
> board-specific.

Agreed.
Wouldn't it be easier to define something like
BR2_POST_BUILD_INSTRUCTIONS (with some nicer well-thought out name)
that's shown when a successful build finishes which points to the proper
documentation and does nothing if unset? (a good old conditional 'cat').
Regards.

  reply	other threads:[~2014-11-27 10:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-26 23:13 [Buildroot] [PATCH RFC] Makefile: from a defconfig file, point to the corresponding board/ entry Yann E. MORIN
2014-11-27 10:26 ` Jérôme Pouiller
2014-11-27 17:46   ` Yann E. MORIN
2014-11-28  8:52     ` Jérôme Pouiller
2014-11-27 10:37 ` Thomas De Schampheleire
2014-11-27 10:41   ` Gustavo Zacarias [this message]
2014-11-27 17:47     ` Yann E. MORIN
2014-11-27 17:58   ` Yann E. MORIN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5476FFF1.8090304@zacarias.com.ar \
    --to=gustavo@zacarias.com.ar \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox