From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] Add a defconfig for MIPS Creator CI20
Date: Mon, 1 Dec 2014 14:28:33 +0000 [thread overview]
Message-ID: <547C7B11.5060203@imgtec.com> (raw)
In-Reply-To: <8761dvh300.fsf@dell.be.48ers.dk>
On 12/01/2014 02:13 PM, Peter Korsgaard wrote:
>>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
>
> >> Exactly: We do some minimal config tweaks to ensure you have a working
> >> setup. See the logic in linux/linux.mk (LINUX_CONFIGURE_CMDS).
>
> > I have seen that file and I found this snippet:
>
> > $(if $(BR2_ROOTFS_DEVICE_CREATION_STATIC),,
> > $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS,$(@D)/.config)
> > $(call KCONFIG_ENABLE_OPT,CONFIG_DEVTMPFS_MOUNT,$(@D)/.config))
>
> > It adds those two options to the kernel config only if
> > BR2_ROOTFS_DEVICE_CREATION_STATIC has been selected. I think this is
> > also needed for BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_DEVTMPFS. I'm going
> > to test it right now to make sure.
>
> No, notice the 2x ",". The syntax of the $(if ) construct is $(if
> <condition>,<command-of-nonempty>,<command-if-empty>), so this is done
> for everything but the static /dev case.
>
> > Also, could you tell me why that if statement has two comma (,,) instead
> > of one? What's the difference with having only one comma?
>
> See above or:
>
> https://www.gnu.org/software/make/manual/html_node/Conditional-Functions.html#index-if
Facepalm.
Thanks Peter, I will send a patch to remove the MDEV option in the
ci20_defconfig.
Cheers,
--
Vicente Olivert Riera
Graduate Software Engineer, MIPS Platforms
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com
prev parent reply other threads:[~2014-12-01 14:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 16:43 [Buildroot] [PATCH v3] Add a defconfig for MIPS Creator CI20 Vicente Olivert Riera
2014-11-29 8:27 ` Peter Korsgaard
2014-12-01 10:14 ` Vicente Olivert Riera
2014-12-01 10:19 ` Peter Korsgaard
2014-12-01 10:31 ` Vicente Olivert Riera
2014-12-01 10:34 ` Peter Korsgaard
2014-12-01 14:05 ` Vicente Olivert Riera
2014-12-01 14:13 ` Peter Korsgaard
2014-12-01 14:28 ` Vicente Olivert Riera [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547C7B11.5060203@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox