From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH branch/next] pinentry: bump version to 0.9.0
Date: Mon, 8 Dec 2014 16:10:40 +0000 [thread overview]
Message-ID: <5485CD80.2080705@imgtec.com> (raw)
In-Reply-To: <20141208165219.313b9967@free-electrons.com>
Dear Thomas Petazzoni,
On 12/08/2014 03:52 PM, Thomas Petazzoni wrote:
> Dear Vicente Olivert Riera,
>
> On Mon, 8 Dec 2014 15:48:01 +0000, Vicente Olivert Riera wrote:
>
>> it was a problem when building pinentry-qt4, which needs to have support
>> for Qt accessibility. Qt accessibility is enabled by default on Qt, but
>> we disable it in Buildroot by passing "-no-accessibility" to the
>> configure script. I don't know why we do that. There is no comment in
>> the .mk file.
>
> Simply because many people probably don't need it, and therefore we
> disabled it by default, waiting for someone who needs it to add an
> option for it.
>
>> When you fix that, you face another problem which is not related with us
>> (Buildroot) but a mistake (that's my opinion) made by the person who
>> released the pinentry tarball. I have reported the issue upstream and
>> written a patch for Buildroot in the meantime.
>>
>> While I was working on all of this, I noticed that the options we had
>> for disablen pinentry-gtk1 and pinentry-qt3 where no longer needed since
>> those options don't exist anymore in the configure script, and the
>> directories gtk and qt don't exist either when you unpack the tarball.
>>
>> Path sent:
>> http://patchwork.ozlabs.org/patch/418743/
>
> The accessibility part should be made optional.
I can send a patch to pinentry to make the accessibility part optional.
Do you prefer I mark my current patch as rejected and do another one
including the patch for making the accessibility part optional instead
of modifying packages/qt/qt.mk?
Cheers,
--
Vicente Olivert Riera
Graduate Software Engineer, MIPS Platforms
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com
next prev parent reply other threads:[~2014-12-08 16:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 16:09 [Buildroot] [PATCH branch/next] pinentry: bump version to 0.9.0 Vicente Olivert Riera
2014-12-07 21:46 ` Yann E. MORIN
2014-12-07 21:53 ` Thomas Petazzoni
2014-12-08 9:22 ` Thomas Petazzoni
2014-12-08 10:05 ` Vicente Olivert Riera
2014-12-08 15:48 ` Vicente Olivert Riera
2014-12-08 15:52 ` Thomas Petazzoni
2014-12-08 16:10 ` Vicente Olivert Riera [this message]
2014-12-08 16:19 ` Thomas Petazzoni
2014-12-08 16:51 ` Vicente Olivert Riera
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5485CD80.2080705@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox