From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/2] dhcpcd: fix build on old toolchains (sa_family_t)
Date: Fri, 02 Jan 2015 22:56:34 +0100 [thread overview]
Message-ID: <54A71412.6030405@lucaceresoli.net> (raw)
In-Reply-To: <20150102191233.1bf32420@free-electrons.com>
Hi Thomas,
Thomas Petazzoni wrote:
> Dear Luca Ceresoli,
>
> On Fri, 2 Jan 2015 17:39:04 +0100, Luca Ceresoli wrote:
>> Fixes error such as:
>> .../sysroot/usr/include/linux/netlink.h:31:2: error: unknown type name 'sa_family_t'
>> .../sysroot/usr/include/linux/netlink.h:31:2: error: expected specifier-qualifier-list before 'sa_family_t'
>>
>> And autobuild failures:
>> http://autobuild.buildroot.net/results/d92/d92e7f2af0e64bc40f7b5c9ea081471de98bf8e8/
>> http://autobuild.buildroot.net/results/e97/e97e980a2f1e0ff4138a6dc03d86ad3ff0973e4a/
>> http://autobuild.buildroot.net/results/ca3/ca32c4de8b645c96cedb80b6270a792e9601ad84/
>>
>> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
>> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>
> But if it's actually the toolchain that is broken, should we instead
> have a patch against the toolchain headers? There are other packages
> that had similar problems with these toolchains.
Honestly I don't know. A few days ago I had the same problem with
dhcpcd 6.6.7 and a pretty old custom toolchain. The issue only emerged
since dhcpcd 6.6.6 (BWHAHAHA!). Changing toolchain was not an option
here, so I came up with this quick fix.
When I saw Baruch's patch today on the list I thought I'd propose my
patch. Maybe I was too quick and should have asked before sending...
At least my solution (o workaround, or whatever) is in the archives,
and anybody with the same problem can find this workaround until a
better solution is available.
--
Luca
prev parent reply other threads:[~2015-01-02 21:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-02 16:39 [Buildroot] [PATCH 1/2] dhcpcd: fix build on old toolchains (sa_family_t) Luca Ceresoli
2015-01-02 16:39 ` [Buildroot] [PATCH 2/2] Revert "dhcpcd: blacklist Sourcery PowerPC toolchains" Luca Ceresoli
2015-01-02 18:11 ` Luca Ceresoli
2015-01-02 18:11 ` [Buildroot] [PATCH 1/2] dhcpcd: fix build on old toolchains (sa_family_t) Luca Ceresoli
2015-01-02 18:12 ` Thomas Petazzoni
2015-01-02 21:56 ` Luca Ceresoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A71412.6030405@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox