From mboxrd@z Thu Jan 1 00:00:00 1970 From: Vicente Olivert Riera Date: Mon, 5 Jan 2015 14:04:42 +0000 Subject: [Buildroot] [PATCH v2] gnupg2: fix linking with intl In-Reply-To: <20141217095737.564714af@free-electrons.com> References: <1418299611-50833-1-git-send-email-Vincent.Riera@imgtec.com> <20141211195331.48f6f7c4@free-electrons.com> <548B0998.5000001@imgtec.com> <20141217095737.564714af@free-electrons.com> Message-ID: <54AA99FA.5010405@imgtec.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 12/17/2014 08:57 AM, Thomas Petazzoni wrote: > Dear Vicente Olivert Riera, > > On Fri, 12 Dec 2014 15:28:24 +0000, Vicente Olivert Riera wrote: >> On 12/11/2014 06:53 PM, Thomas Petazzoni wrote: >>> Dear Vicente Olivert Riera, >>> >>> On Thu, 11 Dec 2014 12:06:51 +0000, Vicente Olivert Riera wrote: >>> >>>> +ifeq ($(BR2_PACKAGE_GETTEXT),y) >>>> +GNUPG2_DEPENDENCIES += gettext >>>> +GNUPG2_CONF_ENV += LIBS=-lintl >>> >>> Are you sure we need this LIBS part when glibc is used? >> >> Uhm..., something must have changed in the tree and right now I'm not >> able to reproduce this failure even using the same config file :/ >> >> http://autobuild.buildroot.net/results/9aa/9aaca74dd3a1f82e12358530db4d5d17eb833f7f/config > > This problem was related to static linking, but the > BR2_PREFER_STATIC_LIB option has been renamed to BR2_STATIC_LIBS (with > a bogus Config.in.legacy handling done by me). So if you took the old > config file, BR2_PREFER_STATIC_LIB was discarded, and you were doing a > shared library build instead of a static library build, which explains > why the problem was not appearing anymore. You were right. So now I was able to reproduce the problem, and taking into account that it only happens for static builds, I think I could change the patch to be like this: ifeq ($(BR2_PACKAGE_GETTEXT),y) GNUPG2_DEPENDENCIES += gettext ifneq ($(BR2_SHARED_LIBS),y) GNUPG2_CONF_ENV += LIBS=-lintl endif endif What do you think? Regards, -- Vicente Olivert Riera Graduate Software Engineer, MIPS Platforms Imagination Technologies Limited t: +44 (0)113 2429814 www.imgtec.com