Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] squid: add sysv initscript
Date: Wed, 14 Jan 2015 17:16:10 -0300	[thread overview]
Message-ID: <54B6CE8A.8030504@zacarias.com.ar> (raw)
In-Reply-To: <20150114205151.18568a75@free-electrons.com>

On 01/14/2015 04:51 PM, Thomas Petazzoni wrote:
> I must say I'm not very happy with those "if something is missing,
> let's bail out silently" tests. We're doing the same in other init
> scripts (as we discussed on IRC), but I think we should probably
> rethink that a bit, and at least display an error message.
> 
> Also, checking for /usr/sbin/squid sound a bit silly, since the init
> script is installed by the squid package, which also has installed the
> squid binary.
> 
> I've nonetheless applied. Follow-up patches welcome, maybe as part of a
> more global overhaul of our init scripts.

I'll write up my proposal tonight and send it to the mailing list since
i've got many ideas already written up.
I don't want to change too many initscripts without a green card first
since it requires quite some testing.
Regards.

  reply	other threads:[~2015-01-14 20:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-14 19:14 [Buildroot] [PATCH 1/2] squid: create a user/group Gustavo Zacarias
2015-01-14 19:14 ` [Buildroot] [PATCH 2/2] squid: add sysv initscript Gustavo Zacarias
2015-01-14 19:51   ` Thomas Petazzoni
2015-01-14 20:16     ` Gustavo Zacarias [this message]
2015-01-14 19:35 ` [Buildroot] [PATCH 1/2] squid: create a user/group Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B6CE8A.8030504@zacarias.com.ar \
    --to=gustavo@zacarias.com.ar \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox