From: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] start-stop-daemon: fix build on non listed architectures
Date: Fri, 16 Jan 2015 10:03:39 +0100 [thread overview]
Message-ID: <54B8D3EB.6030909@imgtec.com> (raw)
In-Reply-To: <80da3f9ea8ed6a75fbd4cbafb1e43843671cd8f0.1421385033.git.baruch@tkos.co.il>
Dear Baruch Siach,
Reviewed-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Tested-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
Best regards,
--
Vicente Olivert Riera
Graduate Software Engineer, MIPS Platforms
Imagination Technologies Limited
t: +44 (0)113 2429814
www.imgtec.com
On 16/01/15 06:10, Baruch Siach wrote:
> Not all Buildroot supported architectures are known to dpkg. Convert the
> configure error to a warning.
>
> Fixes:
> http://autobuild.buildroot.net/results/24e/24e37550749dc15ed7223fd515fa4628803f341e/
> http://autobuild.buildroot.net/results/445/445bf4742d78a0bf93b4c75dc733c4315530031e/
> http://autobuild.buildroot.net/results/952/952051485f23b67ffc449360886d6757c385331f/
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> .../0002-just-warn-on-missing-arch.patch | 19 +++++++++++++++++++
> package/start-stop-daemon/start-stop-daemon.mk | 2 ++
> 2 files changed, 21 insertions(+)
> create mode 100644 package/start-stop-daemon/0002-just-warn-on-missing-arch.patch
>
> diff --git a/package/start-stop-daemon/0002-just-warn-on-missing-arch.patch b/package/start-stop-daemon/0002-just-warn-on-missing-arch.patch
> new file mode 100644
> index 000000000000..2b9cd3db1766
> --- /dev/null
> +++ b/package/start-stop-daemon/0002-just-warn-on-missing-arch.patch
> @@ -0,0 +1,19 @@
> +Just warn on missing arch
> +
> +Some architectures are not listed in dpkg list (e.g. mips64el, xtensa, sh4a).
> +Don't break the build for that.
> +
> +Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> +---
> +diff -Nuar dpkg-1.16.15-orig/m4/dpkg-arch.m4 dpkg-1.16.15/m4/dpkg-arch.m4
> +--- dpkg-1.16.15-orig/m4/dpkg-arch.m4 2014-05-30 02:47:25.000000000 +0300
> ++++ dpkg-1.16.15/m4/dpkg-arch.m4 2015-01-16 06:55:19.701596362 +0200
> +@@ -57,7 +57,7 @@
> + AC_MSG_CHECKING([dpkg architecture name])
> + _DPKG_ARCHITECTURE([DEB_HOST_ARCH], [dpkg_arch])
> + if test "x$dpkg_arch" = "x"; then
> +- AC_MSG_ERROR([cannot determine host dpkg architecture])
> ++ AC_MSG_WARN([cannot determine host dpkg architecture])
> + else
> + AC_MSG_RESULT([$dpkg_arch])
> + fi
> diff --git a/package/start-stop-daemon/start-stop-daemon.mk b/package/start-stop-daemon/start-stop-daemon.mk
> index 021edd19c8cf..5df44d4cfbe1 100644
> --- a/package/start-stop-daemon/start-stop-daemon.mk
> +++ b/package/start-stop-daemon/start-stop-daemon.mk
> @@ -20,6 +20,8 @@ START_STOP_DAEMON_CONF_ENV = \
> dpkg_cv_c99_snprintf=yes
> START_STOP_DAEMON_DEPENDENCIES = host-pkgconf \
> $(if $(BR2_PACKAGE_BUSYBOX),busybox)
> +# Patching m4/dpkg-arch.m4
> +START_STOP_DAEMON_AUTORECONF = YES
> START_STOP_DAEMON_LICENSE = GPLv2+
> START_STOP_DAEMON_LICENSE_FILES = COPYING
>
>
next prev parent reply other threads:[~2015-01-16 9:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 5:10 [Buildroot] [PATCH] start-stop-daemon: fix build on non listed architectures Baruch Siach
2015-01-16 9:03 ` Vicente Olivert Riera [this message]
2015-01-16 21:37 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B8D3EB.6030909@imgtec.com \
--to=vincent.riera@imgtec.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox