From: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] jimtcl: change the way of define JIMTCL_INSTALL_LIB variable
Date: Mon, 19 Jan 2015 08:23:32 +0100 [thread overview]
Message-ID: <54BCB0F4.2050501@trzebnica.net> (raw)
In-Reply-To: <20150118155414.GN4275@free.fr>
Hi Yann,
> Jerzy, All,
>
> On 2015-01-15 18:18 +0100, Jerzy Grzegorek spake thusly:
>> Signed-off-by: Jerzy Grzegorek <jerzy.grzegorek@trzebnica.net>
> Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
> However, there is something really fishy in _INSTALL_STAGING_CMDS:
>
> define JIMTCL_INSTALL_STAGING_CMDS
> for i in $(JIMTCL_HEADERS_TO_INSTALL); do \
> cp -a $(@D)/$$i $(STAGING_DIR)/usr/include/ || exit 1 ; \
> done; \
> $(INSTALL) -D $(@D)/libjim.$(JIMTCL_LIB) $(STAGING_DIR)/usr/lib/libjim.$(JIMTCL_LIB);
> ln -s libjim.$(JIMTCL_LIB) $(STAGING_DIR)/usr/lib/libjim.so
> endef
>
> In case we're static-only, JIMTCL_LIB=a , so we're linking the static
> library to the shared one. Surely this is just busted. no?
Yes, indeed.
>
> While you're at touching jimctl, would you care having a look, please?
OK, will fix.
Thanks for review.
Regards,
Jerzy
>
> Thanks! :-)
>
> Regards,
> Yann E. MORIN.
>
>> ---
>> package/jimtcl/jimtcl.mk | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/package/jimtcl/jimtcl.mk b/package/jimtcl/jimtcl.mk
>> index 75c0382..c2e04ff 100644
>> --- a/package/jimtcl/jimtcl.mk
>> +++ b/package/jimtcl/jimtcl.mk
>> @@ -32,10 +32,11 @@ JIMTCL_INSTALL_LIB =
>> else
>> JIMTCL_SHARED = --shared
>> JIMTCL_LIB = so.$(JIMTCL_VERSION)
>> -JIMTCL_INSTALL_LIB = \
>> +define JIMTCL_INSTALL_LIB
>> $(INSTALL) -D $(@D)/libjim.$(JIMTCL_LIB) \
>> - $(TARGET_DIR)/usr/lib/libjim.$(JIMTCL_LIB); \
>> + $(TARGET_DIR)/usr/lib/libjim.$(JIMTCL_LIB)
>> ln -s libjim.$(JIMTCL_LIB) $(TARGET_DIR)/usr/lib/libjim.so
>> +endef
>> endif
>>
>> define JIMTCL_CONFIGURE_CMDS
>> --
>> 1.7.9.5
>>
>> _______________________________________________
>> buildroot mailing list
>> buildroot at busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
next prev parent reply other threads:[~2015-01-19 7:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 17:18 [Buildroot] [PATCH 1/1] jimtcl: change the way of define JIMTCL_INSTALL_LIB variable Jerzy Grzegorek
2015-01-18 15:54 ` Yann E. MORIN
2015-01-19 7:23 ` Jerzy Grzegorek [this message]
2015-04-01 21:18 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BCB0F4.2050501@trzebnica.net \
--to=jerzy.grzegorek@trzebnica.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox