Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] python-jinja2: add python-markupsafe as dependency
Date: Sun, 25 Jan 2015 00:58:40 +0100	[thread overview]
Message-ID: <54C431B0.4090304@mind.be> (raw)
In-Reply-To: <1422046695-2354-1-git-send-email-erico.nunes@datacom.ind.br>

On 01/23/15 21:58, Erico Nunes wrote:
> BR2_PACKAGE_PYTHON_JINJA2 selects the BR2_PACKAGE_PYTHON_MARKUPSAFE
> option but doesn't depend on it in python-jinja2.mk.
> 
> This turned in an error in an attempt to build python-jinja2 for host:
> "No local packages or download links found for markupsafe"
> 
> Adding the python-markupsafe fixes this error and also ensures that it
> builds before python-jinja2 in any case.

 I've tested it and python-jinja2 builds fine without python-markupsafe.

 It is true that host-python-jinja2 does depend on host-python-markupsafe
(otherwise it will try to download it and we want to avoid that). But then you
should add

HOST_PYTHON_JINJA2_DEPENDENCIES = host-python-markupsafe

to patch 3/3.


 Regards,
 Arnout

> 
> Signed-off-by: Erico Nunes <erico.nunes@datacom.ind.br>
> ---
>  package/python-jinja2/python-jinja2.mk | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/python-jinja2/python-jinja2.mk b/package/python-jinja2/python-jinja2.mk
> index 49625e3..01f743b 100644
> --- a/package/python-jinja2/python-jinja2.mk
> +++ b/package/python-jinja2/python-jinja2.mk
> @@ -10,5 +10,6 @@ PYTHON_JINJA2_SITE = http://pypi.python.org/packages/source/J/Jinja2
>  PYTHON_JINJA2_SETUP_TYPE = setuptools
>  PYTHON_JINJA2_LICENSE = BSD-3c
>  PYTHON_JINJA2_LICENSE_FILES = LICENSE
> +PYTHON_JINJA2_DEPENDENCIES = python-markupsafe
>  
>  $(eval $(python-package))
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  parent reply	other threads:[~2015-01-24 23:58 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-23 20:58 [Buildroot] [PATCH 1/3] python-jinja2: add python-markupsafe as dependency Erico Nunes
2015-01-23 20:58 ` [Buildroot] [PATCH 2/3] python-markupsafe: allow build as host package Erico Nunes
2015-01-25 13:09   ` Arnout Vandecappelle
2015-01-23 20:58 ` [Buildroot] [PATCH 3/3] python-jinja2: " Erico Nunes
2015-01-24 23:58 ` Arnout Vandecappelle [this message]
2015-01-25 14:06   ` [Buildroot] [PATCH 1/3] python-jinja2: add python-markupsafe as dependency Thomas Petazzoni
2015-01-25 15:28     ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C431B0.4090304@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox