Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/4] boot/syslinux: bump version to 6.03
Date: Wed, 28 Jan 2015 01:06:47 +0100	[thread overview]
Message-ID: <54C82817.5060804@openwide.fr> (raw)
In-Reply-To: <20150126232217.04b2fec1@free-electrons.com>

Hi Thomas,

Le 26/01/2015 23:22, Thomas Petazzoni a ?crit :
> Dear Romain Naour,
> 
> On Tue, 20 Jan 2015 00:29:56 +0100, Romain Naour wrote:
>> Remove gnu-efi dependency since it's directly included in
>> syslinux sources since 6.03 release. Also remove the patch
>> for find-gnu-efi.sh script which was removed.
> 
> The script has been renamed to
> output/build/syslinux-6.03/efi/check-gnu-efi.sh. And its contents seems
> to hint that syslinux can use an external gnu-efi installation, which
> would be the preferred solution in Buildroot. Can you investigate this?
> Of course, if there is no upstream supported way of using an external
> gnu-efi installation, then leave things as is in your current patch.

I checked if an external gnu-efi can be used but it's hard coded in
build-gnu-efi.sh.

The gnu-efi build start in mk/efi.mk line 51 by calling:
$(topdir)/efi/check-gnu-efi.sh $(EFI_SUBARCH) $(objdir)

Where:
topdir = output/build/syslinux-6.03
EFI_SUBARCH = ia32
objdir = output/build/syslinux-6.03/efi32 (build output directory)

The script check-gnu-efi.sh test if gnu-efi needs to be build.
If yes, it call build-gnu-efi.sh

The path to gnu-efi is hard coded by EFIDIR:
EFIDIR="$(readlink -f "$objdir/../gnu-efi/gnu-efi-3.0")"

I tried to comment this line and define EFIDIR=$(GNU_EFI_DIR) in
SYSLINUX_BUILD_CMDS.
But there are some build issues to be investigated.

But clearly, external gnu-efi is not supported anymore...

> Also, if the gnu-efi dependency really needs to be removed, you also
> need to remove the "select" in syslinux Config.in file.

Indeed, I forgot to remove the "select", thanks.

> 
> Thanks!
> 
> Thomas
> 

  reply	other threads:[~2015-01-28  0:06 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-19 23:29 [Buildroot] [PATCH 1/4] package/gnu-efi: bump version to 3.0.1 Romain Naour
2015-01-19 23:29 ` [Buildroot] [PATCH 2/4] boot/syslinux: bump version to 6.03 Romain Naour
2015-01-26 22:22   ` Thomas Petazzoni
2015-01-28  0:06     ` Romain Naour [this message]
2015-01-28  8:09       ` Thomas Petazzoni
2015-01-19 23:29 ` [Buildroot] [PATCH 3/4] boot/syslinux: disable MinGW support Romain Naour
2015-01-26 22:23   ` Thomas Petazzoni
2015-01-19 23:29 ` [Buildroot] [PATCH 4/4] boot/syslinux: add host-perl dependency Romain Naour
2015-01-20  8:54   ` Baruch Siach
2015-01-20 20:27     ` Romain Naour
2015-01-26 22:24       ` Thomas Petazzoni
2015-01-26 22:19 ` [Buildroot] [PATCH 1/4] package/gnu-efi: bump version to 3.0.1 Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54C82817.5060804@openwide.fr \
    --to=romain.naour@openwide.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox