Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] automake: use whenever possible the ACLOCAL_DIR variable
Date: Sun, 01 Feb 2015 22:52:31 +0100	[thread overview]
Message-ID: <54CEA01F.5010500@openwide.fr> (raw)
In-Reply-To: <1422809500-23948-2-git-send-email-fabio.porcedda@gmail.com>

Hi Fabio,

Le 01/02/2015 17:51, Fabio Porcedda a ?crit :
> Use the ACLOCAL_DIR in the GTK_DOC_M4_INSTALL hook.
> 
> Move the ACLOCAL_DIR definition at the beginning so the definition is
> ahead the utilization.
> 
> Signed-off-by: Fabio Porcedda <fabio.porcedda@gmail.com>
> ---
>  package/automake/automake.mk | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/automake/automake.mk b/package/automake/automake.mk
> index 5021b49..264cbad 100644
> --- a/package/automake/automake.mk
> +++ b/package/automake/automake.mk
> @@ -12,8 +12,11 @@ AUTOMAKE_LICENSE_FILES = COPYING
>  
>  HOST_AUTOMAKE_DEPENDENCIES = host-autoconf
>  
> +ACLOCAL_DIR = $(HOST_DIR)/usr/share/aclocal
> +
>  define GTK_DOC_M4_INSTALL
> -	$(INSTALL) -D -m 0644 package/automake/gtk-doc.m4 $(HOST_DIR)/usr/share/aclocal/gtk-doc.m4
> +	$(INSTALL) -D -m 0644 package/automake/gtk-doc.m4 \
> +		$(ACLOCAL_DIR)/gtk-doc.m4
>  endef
>  
>  # ensure staging aclocal dir exists
> @@ -28,5 +31,4 @@ $(eval $(host-autotools-package))
>  
>  # variables used by other packages
>  AUTOMAKE = $(HOST_DIR)/usr/bin/automake
> -ACLOCAL_DIR = $(HOST_DIR)/usr/share/aclocal
>  ACLOCAL = $(HOST_DIR)/usr/bin/aclocal -I $(ACLOCAL_DIR)
> 

Reviewed-by: Romain Naour <romain.naour@openwide.fr>

Best regards,
Romain Naour

  reply	other threads:[~2015-02-01 21:52 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-01 16:51 [Buildroot] [PATCH 1/2] automake: complete the removal of the target package Fabio Porcedda
2015-02-01 16:51 ` [Buildroot] [PATCH 2/2] automake: use whenever possible the ACLOCAL_DIR variable Fabio Porcedda
2015-02-01 21:52   ` Romain Naour [this message]
2015-02-02 23:02   ` Peter Korsgaard
2015-02-08 10:48     ` Fabio Porcedda
2015-02-01 21:51 ` [Buildroot] [PATCH 1/2] automake: complete the removal of the target package Romain Naour
2015-02-02 23:01 ` Peter Korsgaard
2015-02-02 23:38   ` Peter Korsgaard
2015-02-08 10:51     ` Fabio Porcedda

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CEA01F.5010500@openwide.fr \
    --to=romain.naour@openwide.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox