Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/3] qt: Force arm mode instead of Thumb1 mode
Date: Mon, 02 Feb 2015 18:35:09 +0100	[thread overview]
Message-ID: <54CFB54D.6070207@mind.be> (raw)
In-Reply-To: <1421753079-27665-3-git-send-email-richard.genoud@gmail.com>

On 20/01/15 12:24, Richard Genoud wrote:
> Qt has some assembly that doesn't exist in thumb1 mode.
> So, force arm mode for Qt
>
> Signed-off-by: Richard Genoud <richard.genoud@gmail.com>

Tested-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>

 It fails when the patch is not applied even on the most minimal
config. It succeeds with the patch applied.


 Regards,
 Arnout

> ---
>  package/qt/qt.mk | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/package/qt/qt.mk b/package/qt/qt.mk
> index 255d6d2ab0e4..80605ca514d5 100644
> --- a/package/qt/qt.mk
> +++ b/package/qt/qt.mk
> @@ -52,6 +52,14 @@ endif
>  
>  endif
>  
> +# Qt has some assembly function that are not present in thumb1 mode:
> +# Error: selected processor does not support Thumb mode `swp r3,r7,[r4]'
> +# so, we desactivate thumb mode
> +ifeq ($(BR2_ARM_INSTRUCTIONS_THUMB),y)
> +QT_CFLAGS += -marm
> +QT_CXXFLAGS += -marm
> +endif
> +
>  ifeq ($(BR2_PACKAGE_QT_QT3SUPPORT),y)
>  QT_CONFIGURE_OPTS += -qt3support
>  else


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F

  reply	other threads:[~2015-02-02 17:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20 11:24 [Buildroot] [PATCH 1/3] dmalloc: Force arm mode instead of Thumb1 mode Richard Genoud
2015-01-20 11:24 ` [Buildroot] [PATCH 2/3] alsa-lib: " Richard Genoud
2015-02-02 17:20   ` Arnout Vandecappelle
2015-02-02 17:29     ` Peter Korsgaard
2015-02-02 17:32     ` Arnout Vandecappelle
2015-01-20 11:24 ` [Buildroot] [PATCH 3/3] qt: " Richard Genoud
2015-02-02 17:35   ` Arnout Vandecappelle [this message]
2015-02-02 20:42   ` Peter Korsgaard
2015-01-25 19:31 ` [Buildroot] [PATCH 1/3] dmalloc: " Thomas Petazzoni
2015-01-26 11:07   ` Richard Genoud
2015-01-26 11:20     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54CFB54D.6070207@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox