Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Boibessot <julien.boibessot@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/opentyrian: fix build on bfin
Date: Tue, 24 Feb 2015 09:24:12 +0100	[thread overview]
Message-ID: <54EC352C.1060503@free.fr> (raw)
In-Reply-To: <20150220092425.408bca64@free-electrons.com>

Dear Thomas,

On 02/20/2015 09:24 AM, Thomas Petazzoni wrote:
> Dear Romain Naour,
>
> On Fri, 20 Feb 2015 01:00:38 +0100, Romain Naour wrote:
>> There is a conflict with the _strchrnul symbole from mingw_fixes.c
>> and the one from uClibc.
>>
>> Add a guard around strchrnul function for unix systems.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/a08/a085fb55269971e3c7b8ae8c167e7330c3c042a5/
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> ---
>>  ...-don-t-redefine-strchrnul-for-unix-system.patch | 42 ++++++++++++++++++++++
>>  1 file changed, 42 insertions(+)
>>  create mode 100644 package/opentyrian/0001-mingw_fixes-don-t-redefine-strchrnul-for-unix-system.patch
> Applied to master, thanks.
>
> Though one may wonder why this mingw_fixes.c file gets compiled at all
> on Unix platforms. Maybe this is what should be fixed instead :)
>
> Seems like Opentyrian is still active upstream:
> https://code.google.com/p/opentyrian/source/list.

I reported the problem to Tyrian upstream, quite at the same time Romain
was fixing it in BR and we missed each other.
They choose a different way to fix it and I will send a patch ASAP to
bump Tyrian to latest version (if you prefer not keeping patches in BR).

Best regards,
Julien

      reply	other threads:[~2015-02-24  8:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-20  0:00 [Buildroot] [PATCH] package/opentyrian: fix build on bfin Romain Naour
2015-02-20  8:24 ` Thomas Petazzoni
2015-02-24  8:24   ` Julien Boibessot [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54EC352C.1060503@free.fr \
    --to=julien.boibessot@free.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox