From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Mednyy Date: Sat, 07 Mar 2015 04:09:43 +0300 Subject: [Buildroot] [PATCH] fix eudev really not depending kernel headers >=3.9 In-Reply-To: <20150306234837.0e201d35@free-electrons.com> References: <1425661783-26577-1-git-send-email-swexru@gmail.com> <20150306234837.0e201d35@free-electrons.com> Message-ID: <54FA4FD7.6080206@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net Dear Thomas Petazzoni, On 03/07/2015 01:48 AM, Thomas Petazzoni wrote: > Dear Alexey Mednyy, > > Thanks for this contribution, see some comments below. > > The commit title should be something like: > > eudev: relax dependency on kernel headers version > > at least, the format should almost always be: > > : > > Also, since the patch is doing not so trivial things, an empty commit > log is a bit strange. Thanks, will fix that in patch v2. > > On Fri, 6 Mar 2015 20:09:43 +0300, Alexey Mednyy wrote: > >> diff --git a/package/eudev/eudev.mk b/package/eudev/eudev.mk >> index 2221966..eb266a1 100644 >> --- a/package/eudev/eudev.mk >> +++ b/package/eudev/eudev.mk >> @@ -10,6 +10,7 @@ EUDEV_SITE = http://dev.gentoo.org/~blueness/eudev >> EUDEV_LICENSE = GPLv2+ (programs), LGPLv2.1+ (libraries) >> EUDEV_LICENSE_FILES = COPYING >> EUDEV_INSTALL_STAGING = YES >> +EUDEV_AUTORECONF = YES > Add a comment above this line saying: > > # We're patching configure.ac > >> # mq_getattr is in librt >> EUDEV_CONF_ENV += LIBS=-lrt >> diff --git a/system/Config.in b/system/Config.in >> index 4d1c3d2..9e2b13f 100644 >> --- a/system/Config.in >> +++ b/system/Config.in >> @@ -128,13 +128,12 @@ config BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV >> depends on BR2_USE_WCHAR >> depends on !BR2_STATIC_LIBS >> depends on BR2_USE_MMU # eudev >> - depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9 >> +# depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9 > On which kernel headers version does eudev now depends? If it really > builds with old 2.6 kernel headers, then just get rid of this line > instead of commenting it out. I'm currently successfully built roots with headers of 2.6.36 and yes I used to delete this line, but forgot it (commented and started test build). Will fix in patch v2. > > However, looking at the eudev source code, I don't see how your > solution can fix the problem. Indeed src/udev/udev-builtin-btrfs.c only > includes if HAVE_LINUX_BTRFS_H is defined. But it uses > BTRFS_IOC_DEVICES_READY unconditionally, and this definition is only > available in . > > Can you expand a little bit on how this can work? Maybe I missed > something obvious? I'm not sure why, but seem older kernels - reason for inclusion of BTRFS_IOC_DEVICES_READY in src/shared/missing.h header in eudev. Thanks. -- _________________________________ Best regards, Mednyy Alexey.