From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 0/3] Cleanup trailing slashed from FOO_SITE
Date: Mon, 09 Mar 2015 23:49:59 +0100 [thread overview]
Message-ID: <54FE2397.1070503@lucaceresoli.net> (raw)
In-Reply-To: <20150309232643.7c1e9495@free-electrons.com>
Dear Thomas,
Thomas Petazzoni wrote:
> Dear Luca Ceresoli,
>
> On Mon, 9 Mar 2015 23:14:49 +0100, Luca Ceresoli wrote:
>
>> Luca Ceresoli (3):
>> manual: download: remove trailing slash from package FOO_SITE
>> Remove trailing slash from all package site URLs
>> Download: remove trailing slash cleanups for SITE URLs
>
> Sounds good, but shouldn't we add a check to make sure that such
> trailing slashes don't get added again? Like a check in pkg-generic.mk
> that verifies that $($(2)_SITE) is the same as $($(2)_SITE:=/) ?
Sure, good idea.
I had been thinking about some sort of checkpatch.pl to prevent such
errors, but it would probably be uselessly complex so I didn't go down
that path.
I'll have a look at implementing what you suggest.
--
Luca
next prev parent reply other threads:[~2015-03-09 22:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-09 22:14 [Buildroot] [PATCH 0/3] Cleanup trailing slashed from FOO_SITE Luca Ceresoli
2015-03-09 22:14 ` [Buildroot] [PATCH 1/3] manual: download: remove trailing slash from package FOO_SITE Luca Ceresoli
2015-03-09 22:14 ` [Buildroot] [PATCH 2/3] Remove trailing slash from all package site URLs Luca Ceresoli
2015-03-09 22:14 ` [Buildroot] [PATCH 3/3] Download: remove trailing slash cleanups for SITE URLs Luca Ceresoli
2015-03-09 22:26 ` [Buildroot] [PATCH 0/3] Cleanup trailing slashed from FOO_SITE Thomas Petazzoni
2015-03-09 22:49 ` Luca Ceresoli [this message]
2015-03-10 19:41 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54FE2397.1070503@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox