Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libpcap: update libnl fix patch
Date: Sat, 14 Mar 2015 13:20:34 +0100	[thread overview]
Message-ID: <55042792.4020307@openwide.fr> (raw)
In-Reply-To: <1426332075-25023-1-git-send-email-gustavo@zacarias.com.ar>

Hi Gustavo,

Le 14/03/2015 12:21, Gustavo Zacarias a ?crit :
> We also need to nuke bad LIBS assumptions, fixes:
> http://autobuild.buildroot.net/results/bbd/bbde2b62d4b677e71a62b25fb9ccb4ac4764a4aa/
> http://autobuild.buildroot.net/results/5de/5dedfb19df476a633e4449d44e7ba2778bf5b737/
> ...and lots more of those kind.
> 
> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
> ---

Before your patch, pcap-config --static --libs returned "-Llinux/lib/.libs" and
that why tcpreplay package was broken.

Build tested with this patch applied, now "-Llinux/lib/.libs" is gone.

Reviewed-by: Romain Naour <romain.naour@openwide.fr>
Tested-by: Romain Naour <romain.naour@openwide.fr>

Best regards,
Romain

>  package/libpcap/0001-remove-libnl-include-path.patch | 14 ++++++++++----
>  1 file changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/package/libpcap/0001-remove-libnl-include-path.patch b/package/libpcap/0001-remove-libnl-include-path.patch
> index a4039ef..d0760d4 100644
> --- a/package/libpcap/0001-remove-libnl-include-path.patch
> +++ b/package/libpcap/0001-remove-libnl-include-path.patch
> @@ -4,16 +4,22 @@ Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>  [Gustavo: update for 1.7.2]
>  
>  diff -Nura libpcap-1.7.2.orig/configure.in libpcap-1.7.2/configure.in
> ---- libpcap-1.7.2.orig/configure.in	2015-03-11 10:02:44.416189921 -0300
> -+++ libpcap-1.7.2/configure.in	2015-03-11 10:03:03.967633673 -0300
> -@@ -466,9 +466,8 @@
> +--- libpcap-1.7.2.orig/configure.in	2015-03-14 08:02:05.538706347 -0300
> ++++ libpcap-1.7.2/configure.in	2015-03-14 08:17:22.637519050 -0300
> +@@ -461,14 +461,13 @@
> + 			#
> + 			# Yes, we have libnl 3.x.
> + 			#
> +-			LIBS="${libnldir} -lnl-genl-3 -lnl-3 $LIBS"
> ++			LIBS="-lnl-genl-3 -lnl-3 $LIBS"
> + 			AC_DEFINE(HAVE_LIBNL,1,[if libnl exists])
>   			AC_DEFINE(HAVE_LIBNL_3_x,1,[if libnl exists and is version 3.x])
>   			AC_DEFINE(HAVE_LIBNL_NLE,1,[libnl has NLE_FAILURE])
>   			AC_DEFINE(HAVE_LIBNL_SOCKETS,1,[libnl has new-style socket api])
>  -			V_INCLS="$V_INCLS ${incdir}"
>   			have_any_nl="yes"
>  -		],[], ${incdir} ${libnldir} -lnl-genl-3 -lnl-3 )
> -+		],[], ${libnldir} -lnl-genl-3 -lnl-3 )
> ++		],[], -lnl-genl-3 -lnl-3 )
>   
>   		if test x$have_any_nl = xno ; then
>   			#
> 

  reply	other threads:[~2015-03-14 12:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-14 11:21 [Buildroot] [PATCH] libpcap: update libnl fix patch Gustavo Zacarias
2015-03-14 12:20 ` Romain Naour [this message]
2015-03-14 12:28 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55042792.4020307@openwide.fr \
    --to=romain.naour@openwide.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox