From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 5/7] pkg-generic: allow full URLs for <pkg>_EXTRA_DOWNLOADS
Date: Sun, 15 Mar 2015 17:45:29 +0100 [thread overview]
Message-ID: <5505B729.3000701@openwide.fr> (raw)
In-Reply-To: <1425147313-17380-6-git-send-email-thomas.petazzoni@free-electrons.com>
Hi Thomas,
Le 28/02/2015 19:15, Thomas Petazzoni a ?crit :
> The current logic for <pkg>_EXTRA_DOWNLOADS assumes that it is a list
> of files, all hosted at <pkg>_SITE. However, just like for
> <pkg>_PATCH, it may be useful to specify <pkg>_EXTRA_DOWNLOADS entries
> that are hosted on a different site than the package <pkg>_SITE.
>
> This commit implements this, by re-using the same logic as the one
> used for <pkg>_PATCH.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
Reviewed-by: Romain Naour <romain.naour@openwide.fr>
> package/pkg-generic.mk | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk
> index 7a9da43..85b22de 100644
> --- a/package/pkg-generic.mk
> +++ b/package/pkg-generic.mk
> @@ -81,7 +81,12 @@ ifeq ($(DL_MODE),DOWNLOAD)
> done
> endif
> $(if $($(PKG)_SOURCE),$(call DOWNLOAD,$($(PKG)_SITE:/=)/$($(PKG)_SOURCE)))
> - $(foreach p,$($(PKG)_EXTRA_DOWNLOADS),$(call DOWNLOAD,$($(PKG)_SITE:/=)/$(p))$(sep))
> + $(foreach p,$($(PKG)_EXTRA_DOWNLOADS),\
> + $(if $(findstring ://,$(p)),\
> + $(call DOWNLOAD,$(p)),\
> + $(call DOWNLOAD,$($(PKG)_SITE:/=)/$(p))\
> + )\
> + $(sep))
> $(foreach p,$($(PKG)_PATCH),\
> $(if $(findstring ://,$(p)),\
> $(call DOWNLOAD,$(p)),\
>
next prev parent reply other threads:[~2015-03-15 16:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-28 18:15 [Buildroot] [PATCH 0/7] Improvements to the download logic Thomas Petazzoni
2015-02-28 18:15 ` [Buildroot] [PATCH 1/7] linux: use the package infrastructure to download patches Thomas Petazzoni
2015-02-28 19:54 ` Baruch Siach
2015-03-15 14:59 ` Romain Naour
2015-03-15 15:14 ` Thomas Petazzoni
2015-03-15 15:58 ` Romain Naour
2015-03-22 15:15 ` Arnout Vandecappelle
2015-03-15 16:44 ` Romain Naour
2015-03-22 15:16 ` Arnout Vandecappelle
2015-02-28 18:15 ` [Buildroot] [PATCH 2/7] pkg-generic: fix the logic showing the "Downloading" message Thomas Petazzoni
2015-03-15 16:44 ` Romain Naour
2015-03-22 15:19 ` Arnout Vandecappelle
2015-02-28 18:15 ` [Buildroot] [PATCH 3/7] pkg-generic: take into account <pkg>_EXTRA_DOWNLOADS to display " Thomas Petazzoni
2015-03-15 16:44 ` Romain Naour
2015-03-22 15:20 ` Arnout Vandecappelle
2015-02-28 18:15 ` [Buildroot] [PATCH 4/7] pkg-generic: refactor the "Downloading" message logic Thomas Petazzoni
2015-03-15 16:44 ` Romain Naour
2015-03-22 15:29 ` Arnout Vandecappelle
2015-02-28 18:15 ` [Buildroot] [PATCH 5/7] pkg-generic: allow full URLs for <pkg>_EXTRA_DOWNLOADS Thomas Petazzoni
2015-03-15 16:45 ` Romain Naour [this message]
2015-03-22 15:33 ` Arnout Vandecappelle
2015-02-28 18:15 ` [Buildroot] [PATCH 6/7] docs/manual: update documentation about <pkg>_SOURCE, <pkg>_PATCH and <pkg>_EXTRA_DOWNLOADS Thomas Petazzoni
2015-03-15 16:45 ` Romain Naour
2015-03-22 15:58 ` Arnout Vandecappelle
2015-02-28 18:15 ` [Buildroot] [PATCH 7/7] perl: use <pkg>_EXTRA_DOWNLOADS Thomas Petazzoni
2015-03-15 16:46 ` Romain Naour
2015-03-22 15:59 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5505B729.3000701@openwide.fr \
--to=romain.naour@openwide.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox