From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 1/2] package/avrdude: optionally depends on libftdi or libftdi1
Date: Thu, 19 Mar 2015 00:58:31 +0100 [thread overview]
Message-ID: <550A1127.4080701@mind.be> (raw)
In-Reply-To: <1426613796-4921-1-git-send-email-s.martin49@gmail.com>
On 17/03/15 18:36, Samuel Martin wrote:
> Avrdude supports both libftdi and libftdi1.
>
> Because libftdi is already an optional dependency, this patch adds
> libftdi1 as optional dependency as well, but privileges libftdi1 over
> libftdi (accdording to what is done in avrdude's configure script).
>
> Signed-off-by: Samuel Martin <s.martin49@gmail.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
>
> ---
> changes v2->v3:
> - rebase
> - re-introduce optional libftdi dependency (ThomasP)
> - reword commit log
>
> changes v1->v2:
> - rebase
> ---
> package/avrdude/avrdude.mk | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/package/avrdude/avrdude.mk b/package/avrdude/avrdude.mk
> index 03d6490..1811893 100644
> --- a/package/avrdude/avrdude.mk
> +++ b/package/avrdude/avrdude.mk
> @@ -17,7 +17,9 @@ AVRDUDE_DEPENDENCIES = elfutils libusb libusb-compat ncurses \
> AVRDUDE_LICENSE = GPLv2+
> AVRDUDE_LICENSE_FILES = avrdude/COPYING
>
> -ifeq ($(BR2_PACKAGE_LIBFTDI),y)
> +ifeq ($(BR2_PACKAGE_LIBFTDI1),y)
> +AVRDUDE_DEPENDENCIES += libftdi1
> +else ifeq ($(BR2_PACKAGE_LIBFTDI),y)
> AVRDUDE_DEPENDENCIES += libftdi
> endif
>
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2015-03-18 23:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 17:36 [Buildroot] [PATCH v3 1/2] package/avrdude: optionally depends on libftdi or libftdi1 Samuel Martin
2015-03-17 17:36 ` [Buildroot] [PATCH v3 2/2] package/openocd: depends on libftdi1 instead of libftdi Samuel Martin
2015-03-18 23:58 ` Arnout Vandecappelle
2015-03-18 23:58 ` Arnout Vandecappelle [this message]
2015-03-20 22:30 ` [Buildroot] [PATCH v3 1/2] package/avrdude: optionally depends on libftdi or libftdi1 Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550A1127.4080701@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox