From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/5 v2] support/download: make hash file optional
Date: Thu, 19 Mar 2015 21:34:32 +0100 [thread overview]
Message-ID: <550B32D8.9050302@mind.be> (raw)
In-Reply-To: <26bebad3dca4191b35ddb2dae535b15de9a883c2.1426597114.git.yann.morin.1998@free.fr>
On 17/03/15 13:59, Yann E. MORIN wrote:
> Currently, specifying a hash file for our download wrapper is mandatory.
>
> However, when we download a git, svn, bzr, hg or cvs tree, there's by
> design no hash to check the download against.
>
> Since we're going to have hash checking mandatory when a hash file
> exists, this would break those downloads from a repository.
>
> So, make specifying a hash file optional when calling our download
> wrapper and bail out early from the check-hash script if no hash file is
> specified.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
I would actually have squashed the following patch into this one, since for
reviewing you anyway have to look at the two together.
Regards,
Arnout
> ---
> support/download/check-hash | 2 +-
> support/download/dl-wrapper | 3 ---
> 2 files changed, 1 insertion(+), 4 deletions(-)
[snip]
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2015-03-19 20:34 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-17 12:59 [Buildroot] [PATCH 0/5 v2] support/download: be more aggressive on missing hashes (branch yem/dl-hash) Yann E. MORIN
2015-03-17 12:59 ` [Buildroot] [PATCH 1/5 v2] support/download: make hash file optional Yann E. MORIN
2015-03-19 20:34 ` Arnout Vandecappelle [this message]
2015-03-19 21:03 ` Arnout Vandecappelle
2015-03-21 17:00 ` Yann E. MORIN
2015-03-21 17:28 ` Arnout Vandecappelle
2015-03-17 12:59 ` [Buildroot] [PATCH 2/5 v2] package infra: do not check hashes when downloading from a repository Yann E. MORIN
2015-03-19 20:36 ` Arnout Vandecappelle
2015-03-17 12:59 ` [Buildroot] [PATCH 3/5 v2] support/download: return different exit codes for different failures Yann E. MORIN
2015-03-19 20:44 ` Arnout Vandecappelle
2015-03-17 12:59 ` [Buildroot] [PATCH 4/5 v2] support/download: properly catch missing hashes Yann E. MORIN
2015-03-19 20:45 ` Arnout Vandecappelle
2015-03-17 12:59 ` [Buildroot] [PATCH 5/5 v2] support/download: always fail when there's no hash Yann E. MORIN
2015-03-19 20:51 ` Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=550B32D8.9050302@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox