From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Thu, 19 Mar 2015 22:03:13 +0100 Subject: [Buildroot] [PATCH 1/5 v2] support/download: make hash file optional In-Reply-To: <26bebad3dca4191b35ddb2dae535b15de9a883c2.1426597114.git.yann.morin.1998@free.fr> References: <26bebad3dca4191b35ddb2dae535b15de9a883c2.1426597114.git.yann.morin.1998@free.fr> Message-ID: <550B3991.8090509@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 17/03/15 13:59, Yann E. MORIN wrote: > Currently, specifying a hash file for our download wrapper is mandatory. > > However, when we download a git, svn, bzr, hg or cvs tree, there's by > design no hash to check the download against. > > Since we're going to have hash checking mandatory when a hash file > exists, this would break those downloads from a repository. > > So, make specifying a hash file optional when calling our download > wrapper and bail out early from the check-hash script if no hash file is > specified. An alternative approach would be to allow an empty hash in the hash file, e.g. # From git => no hash none xxx avrdude-eabe067c4527bc2eedc5db9288ef5cf1818ec720.tar.gz This has the advantage that we don't have to revert this patch in the future when we _do_ make reproducible tarballs (which is not rocket science, the reproducible builds people in Debian and Fedora do it). Of course, we'll be stuck with a s*tload of hash files that have this empty hash... Regards, Arnout -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F