From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Mon, 06 Apr 2015 23:03:43 +0200 Subject: [Buildroot] [PATCH 5/6 v3] toolchain/external: ignore missing hash for custom downloaded toolchain In-Reply-To: <2e8ef15e2d2d729ffe1bb5f77aabeb525554c407.1428322317.git.yann.morin.1998@free.fr> References: <2e8ef15e2d2d729ffe1bb5f77aabeb525554c407.1428322317.git.yann.morin.1998@free.fr> Message-ID: <5522F4AF.7000409@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On 06/04/15 14:13, Yann E. MORIN wrote: > We will *always* be missing a hash file for custom external toolchains > that are downloaded. > > So, just ignore that failure. > > Signed-off-by: "Yann E. MORIN" > Cc: Thomas Petazzoni > Cc: Gustavo Zacarias > > --- > Changes v1 -> v2: > - fix typoes in title > --- > toolchain/toolchain-external/toolchain-external.mk | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/toolchain/toolchain-external/toolchain-external.mk b/toolchain/toolchain-external/toolchain-external.mk > index c0429bb..3659511 100644 > --- a/toolchain/toolchain-external/toolchain-external.mk > +++ b/toolchain/toolchain-external/toolchain-external.mk > @@ -400,6 +400,8 @@ else > # Custom toolchain > TOOLCHAIN_EXTERNAL_SITE = $(dir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL))) > TOOLCHAIN_EXTERNAL_SOURCE = $(notdir $(call qstrip,$(BR2_TOOLCHAIN_EXTERNAL_URL))) > +# Magic value to tell the download helper to avoid failling on missing hash > +export BR_MISSING_HASH_OK := $(call ignore-missing-hash-magic,$(TOOLCHAIN_EXTERNAL_SOURCE)) Urgh - this disables the hash check for all packages, not just the toolchain. So NACK for exporting it. But I see that it's not so simple to get it into the environment of the download step... Perhaps instead we should add a global variable with the files that should not be hash-checked: NOHASH_FILES += $(TOOLCHAIN_EXTERNAL_SOURCE) and in pkg-download.mk hasharg = $(if $(filter-out $(TOOLCHAIN_EXTERNAL_SOURCE),$(1)), -H $(PKGDIR)/$($(PKG)_RAWNAME).hash) define DOWNLOAD_WGET $(EXTRA_ENV) $(DL_WRAPPER) -b wget \ -o $(DL_DIR)/$(2) \ $(call hasharg,$(2)) \ $(QUIET) \ -- \ '$(call qstrip,$(1))' endef (all completely untested, obviously :-) Regards, Arnout > endif > > # In fact, we don't need to download the toolchain, since it is already > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F