From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] pkg-generic: support patching local source code
Date: Fri, 10 Apr 2015 23:08:12 +0200 [thread overview]
Message-ID: <55283BBC.1040708@mind.be> (raw)
In-Reply-To: <CAB7JjA_Xc3ZCpT8RME2_nPjAGiDmp_k+yYOyvih7Bq9BSuShDA@mail.gmail.com>
Hi Nicolas,
[Please don't top-post]
On 10/04/15 00:21, Nicolas Dade wrote:
> Let me explain what led me to allow patches to local source. My local source
> isn't mine. It's an SDK from the vendor of a part I'm using. The vendor is much
> better at hardware than software, and their SDK doesn't build as-is. So I need
> to patch it. I also need to maintain my patches separated from the SDK since the
> vendor publishes updates to their SDK every month or so.
>
> So what I am doing is having the vendor's SDK source code unzip'ed in one
> directory, and have buildroot use [subtrees of] that directory as the local
> source, patch it with my fixes, and build it.
Instead of unzipping the source code, leave it as an archive (if it is really a
zipfile instead of a tarball, you'll need to supply custom EXTRACT_CMDS). Then
the patches still are applied. And it gives you much more flexibility to put the
>
> PS I also thought that not allowing patching only for local sources was a
> strange asymmetry in buildroot. I expected local sources to work the same as
> tarballs.
We probably should get rid of the 'local' site method, since it is indeed
confusing and serves no purpose as far as I'm concerned.
Regards,
Arnout
> It wasn't until I looked into the buildroot make system that I
> realized why my patches weren't getting applied. So if you don't accept this
> patch, at least you might document that local sources cannot be patched in a
> clear way.
>
[snip]
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2015-04-10 21:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-09 0:28 [Buildroot] [PATCH 1/1] pkg-generic: support patching local source code Nicolas S. Dade
2015-04-09 22:12 ` Yann E. MORIN
2015-04-09 22:21 ` Nicolas Dade
2015-04-09 22:40 ` Yann E. MORIN
[not found] ` <CAB7JjA_EKRS9uEX9MhgUVpovh4VKoUF2vx1wE2Q+a9baZTRyCQ@mail.gmail.com>
2015-04-10 17:30 ` Yann E. MORIN
2015-04-10 21:08 ` Arnout Vandecappelle [this message]
2015-04-10 21:31 ` Nicolas Dade
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55283BBC.1040708@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox