From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnout Vandecappelle Date: Tue, 14 Apr 2015 01:56:02 +0200 Subject: [Buildroot] [PATCH 8/8 v4] support/download: do not accept exlcuded files with ashes In-Reply-To: References: Message-ID: <552C5792.6090606@mind.be> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net In subject: excluded hashes However, I'm not so sure of this one. Let's say that I configure a custom toolchain that comes from Linaro, and later on upstream buildroot adds official support for this toolchain including a hash, then suddenly I'll get an error for my custom toolchain... Also: On 08/04/15 18:57, Yann E. MORIN wrote: > If a file is excluded from checking its hashes, it must effectively have > no hash for it. > > So, if an excluded file indeed has at least one hash, there is an issue > somewhere; that file should probably not be excluded. > > When this happens, bail out in error. > > Signed-off-by: "Yann E. MORIN" > Cc: Thomas Petazzoni > Cc: Gustavo Zacarias > Cc: Arnout Vandecappelle > --- > support/download/check-hash | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/support/download/check-hash b/support/download/check-hash > index 96f5965..849637e 100755 > --- a/support/download/check-hash > +++ b/support/download/check-hash > @@ -18,6 +18,9 @@ set -e > # one of its hashes > # 3: the hash file exists and there was no hash to check the file against > # 4: the hash file exists and at least one hash type is unknown > +# 5: the hash file exists and there was at least one hash for the file > +# to check and all those hashes did match, but the file is excluded > +# from being checked > > while getopts :q OPT; do > case "${OPT}" in > @@ -106,4 +109,11 @@ if [ ${nb_checks} -eq 0 ]; then > done > printf "ERROR: No hash found for %s\n" "${base}" >&2 > exit 3 > +else > + for f in ${BR_NO_CHECK_HASH_FOR}; do > + if [ "${f}" = "${base}" ]; then > + printf "ERROR: Hash found for excluded %s\n" "${base}" >&2 > + exit 5 > + fi > + done I'd move this check before actually checking the hash; I have the feeling it will be pretty likely that the hashes will mismatch when this error occurs, and then this error is probably the root issue. Regards, Arnout > fi > -- Arnout Vandecappelle arnout at mind be Senior Embedded Software Architect +32-16-286500 Essensium/Mind http://www.mind.be G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F