From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] live555: fix library installation
Date: Mon, 20 Apr 2015 10:38:11 +0200 [thread overview]
Message-ID: <5534BAF3.1080305@lucaceresoli.net> (raw)
In-Reply-To: <20150419134235.18c914b0@free-electrons.com>
Dear Thomas,
Thomas Petazzoni wrote:
> Dear Luca Ceresoli,
>
> On Thu, 16 Apr 2015 16:50:50 +0200, Luca Ceresoli wrote:
>> The manual target installation commands optionally copies 3 executables
>> that demonstrate the library usage, but do not the library itself.
>>
>> This results in the following errors at runtime:
>>
>> # openRTSP
>> openRTSP: can't load library 'libliveMedia.so.38'
>> # live555MediaServer
>> live555MediaServer: can't load library 'libliveMedia.so.38'
>> # MPEG2TransportStreamIndexer
>> MPEG2TransportStreamIndexer: can't load library 'libliveMedia.so.38'
>> #
>
> I understand the issue, but I'm not entirely happy with the solution.
> There are some options BR2_PACKAGE_LIVE555_OPENRTSP,
> BR2_PACKAGE_LIVE555_MEDIASERVER, etc. to control which tools to
> install. But with your new patch, regardless of the value of those
> options, a lot of other programs (tests and others) are installed.
> Which make the existing per-program options a bit weird/useless.
>
> I would personally advocate for a simple removal of the per-program
> options, just install everything, and leave it to post-build scripts to
> clean up what's needed.
Wow, this means removing dozens of lines of code... great!
At first I just wanted to keep a sort of "backward compatibility", at
least at the configure level. But I really prefer to simplify the
package by installing everything.
I'm sending an update v2 patch.
BTW, there should be a simple way to skip installation of all
executables, by tweaking the live555 makefiles. But I don't think it
would be very nice to conditionally apply a patch based on config
options. Do you agree?
--
Luca
next prev parent reply other threads:[~2015-04-20 8:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-16 14:50 [Buildroot] [PATCH] live555: fix library installation Luca Ceresoli
2015-04-19 11:42 ` Thomas Petazzoni
2015-04-20 8:38 ` Luca Ceresoli [this message]
2015-04-20 8:56 ` Thomas Petazzoni
2015-04-20 9:00 ` Luca Ceresoli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5534BAF3.1080305@lucaceresoli.net \
--to=luca@lucaceresoli.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox