From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC] package/boost: fix powerpc uClibc build issue
Date: Fri, 15 May 2015 21:22:56 +0200 [thread overview]
Message-ID: <55564790.3020109@openwide.fr> (raw)
In-Reply-To: <20150515204256.7028a9d1@free-electrons.com>
Hi Thomas,
Le 15/05/2015 20:42, Thomas Petazzoni a ?crit :
> Dear Romain Naour,
>
> On Fri, 15 May 2015 19:00:07 +0200, Romain Naour wrote:
>> With powerpc target and uClibc toolchain the spirit library doesn't
>> build properly due to an invalid field access.
>>
>> The "bits" field is intended only for internal use in
>> include/boost/math/special_functions/sign.hpp not from
>> include/boost/spirit/home/support/detail/sign.hpp.
>>
>> Simply call (boost::math::changesign)(x) from
>> include/boost/spirit/home/support/detail/sign.hpp to fixes this.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/be1/be1069e8528d299f487f431f7e2d793413ccbab8/
>>
>> And many more.
>>
>> Signed-off-by: Romain Naour <romain.naour@openwide.fr>
>> ---
>> It's not clear why this issue is only trigged by powerpc
>> with uClibc toolchain.
>> Also, it's a pity that the spirit library doesn't use directly
>> math library instead of using a wrapper.
>
> My opinion is that this patch is too tricky to be committed without
> being checked by upstream Boost developers, especially since there is
> no explanation as to why the problem occurs only on PowerPC.
>
> I would prefer to disable boost-log on PowerPC/uClibc, as proposed by
> the patch I submitted shortly after this one.
I'm agree with your proposal and I'll wait for upstream comment on this patch:
http://sourceforge.net/p/spirit/mailman/message/34116604/
Best regards,
Romain
> Best regards,
>
> Thomas
>
prev parent reply other threads:[~2015-05-15 19:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 17:00 [Buildroot] [RFC] package/boost: fix powerpc uClibc build issue Romain Naour
2015-05-15 18:42 ` Thomas Petazzoni
2015-05-15 19:22 ` Romain Naour [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55564790.3020109@openwide.fr \
--to=romain.naour@openwide.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox