Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/iproute2: disable iptables support for static build
Date: Sat, 23 May 2015 12:02:35 +0200	[thread overview]
Message-ID: <5560503B.2060606@openwide.fr> (raw)
In-Reply-To: <87vbfl39tk.fsf@dell.be.48ers.dk>

Hi Peter,

Le 21/05/2015 23:22, Peter Korsgaard a ?crit :
>>>>>> "Romain" == Romain Naour <romain.naour@openwide.fr> writes:
> 
>  > If iptable support is enabled, it will try to build m_xt.so even
>  > for static build only.
> 
>  > So, disable iptables support for static build and remove
>  > TC_CONFIG_IPSET and TC_CONFIG_XT if previously added by the
>  > configure script.
> 
>  > Fixes:
>  > http://autobuild.buildroot.net/results/3b3/3b37871bdf5766677fc20dca22c13177091d104f/
> 
> FYI, I ended up applying Baruch's patch (and then some followup patches
> of my own). Your two patches were almost identical, but for his patch I
> didn't have to drop the SED lines, and I was lazy ;)

Ok, no problem and sorry for the late answer...

The sed invocation to remove -Werror is just a nop and can also be removed.
See:
http://git.kernel.org/cgit/linux/kernel/git/shemminger/iproute2.git/commit/?id=3140e9a3a343d37a8d828ee27e16ad9f3f9ab389

The real fix would be to write a real autotools configure script but it's
probably too late for the Buildroot release...

See also the note in the commit log ;-)
http://git.kernel.org/cgit/linux/kernel/git/shemminger/iproute2.git/commit/?id=06ec9039c3aa07924f9c23b0daa8885204704a62

Best regards,
Romain

> 
> Thanks!
> 

  reply	other threads:[~2015-05-23 10:02 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-18 20:54 [Buildroot] [PATCH] package/iproute2: disable iptables support for static build Romain Naour
2015-05-19 19:33 ` Peter Korsgaard
2015-05-20  3:57   ` Gustavo Zacarias
2015-05-21 21:22 ` Peter Korsgaard
2015-05-23 10:02   ` Romain Naour [this message]
2015-05-25 20:32     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5560503B.2060606@openwide.fr \
    --to=romain.naour@openwide.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox