From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 09/11 v2] package/owl-linux: use kernel-module helper
Date: Fri, 12 Jun 2015 01:13:10 +0200 [thread overview]
Message-ID: <557A1606.1030402@mind.be> (raw)
In-Reply-To: <e63af963671131bf2d33fd2ab2eaa351bcc51150.1433964001.git.yann.morin.1998@free.fr>
On 06/10/15 21:22, Yann E. MORIN wrote:
> Git rid of first patch, no longer needed; rename remaining patch.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>
[snip]
> diff --git a/package/owl-linux/owl-linux.mk b/package/owl-linux/owl-linux.mk
> index 371cc02..844b11e 100644
> --- a/package/owl-linux/owl-linux.mk
> +++ b/package/owl-linux/owl-linux.mk
> @@ -10,14 +10,11 @@ OWL_LINUX_LICENSE = PROPRIETARY
> OWL_LINUX_LICENSE_FILES = LICENSE
> OWL_LINUX_REDISTRIBUTE = NO
>
> -OWL_LINUX_DEPENDENCIES = linux
> -
> -define OWL_LINUX_BUILD_CMDS
> - $(MAKE) -C $(@D) $(LINUX_MAKE_FLAGS) KERNELDIR=$(LINUX_DIR)
> -endef
> -
> -define OWL_LINUX_INSTALL_TARGET_CMDS
> - $(MAKE) -C $(LINUX_DIR) $(LINUX_MAKE_FLAGS) M="$(@D)" modules_install
> -endef
> +# owl-linux wants to use $(PWD) to find its includes, however $(PWD) is not
> +# the top of the package's source tree, but the top of Buildroot source tree
Unless I'm very much mistaken, PWD will be $(LINUX_DIR) when the Makefile is
included.
With that small thing fixed:
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> +# $(TOPDIR) (i.e. the place where make is run from).
> +# So, override PWD to the proper value.
> +OWL_LINUX_MODULE_MAKE_OPTS = PWD=$(@D)
>
> +$(eval $(kernel-module))
> $(eval $(generic-package))
>
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7CB5 E4CC 6C2E EFD4 6E3D A754 F963 ECAB 2450 2F1F
next prev parent reply other threads:[~2015-06-11 23:13 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-10 19:22 [Buildroot] [PATCH 0/11 v2] pkg-kernel-module: new infra to ease building kernel modules (branch yem/kernel-modules) Yann E. MORIN
2015-06-10 19:22 ` [Buildroot] [PATCH 01/11 v2] package-infra: add helper to build kernel modules Yann E. MORIN
2015-06-10 21:08 ` rdkehn at yahoo.com
2015-06-11 18:05 ` Yann E. MORIN
2015-06-11 22:44 ` Arnout Vandecappelle
2015-06-12 17:46 ` Yann E. MORIN
2015-06-12 22:52 ` Arnout Vandecappelle
2015-06-10 19:22 ` [Buildroot] [PATCH 02/11 v2] docs/manual: add kernel-module Yann E. MORIN
2015-06-11 7:32 ` Jeremy Rosen
2015-06-11 18:06 ` Yann E. MORIN
2015-06-12 6:54 ` Jeremy Rosen
2015-06-10 19:22 ` [Buildroot] [PATCH 03/11 v2] package/lttng-modules: use kernel-module helper Yann E. MORIN
2015-06-11 22:44 ` Arnout Vandecappelle
2015-06-10 19:22 ` [Buildroot] [PATCH 04/11 v2] package/igh-ethercat: " Yann E. MORIN
2015-06-11 22:51 ` Arnout Vandecappelle
2015-06-10 19:22 ` [Buildroot] [PATCH 05/11 v2] package/ktap: " Yann E. MORIN
2015-06-11 22:53 ` Arnout Vandecappelle
2015-06-10 19:22 ` [Buildroot] [PATCH 06/11 v2] package/cryptodev-linux: use the " Yann E. MORIN
2015-06-11 23:02 ` Arnout Vandecappelle
2015-06-12 20:48 ` Yann E. MORIN
2015-06-10 19:22 ` [Buildroot] [PATCH 07/11 v2] package/ocf-linux: use " Yann E. MORIN
2015-06-10 19:22 ` [Buildroot] [PATCH 08/11 v2] package/on2-8170-modules: " Yann E. MORIN
2015-06-11 23:04 ` Arnout Vandecappelle
2015-06-10 19:22 ` [Buildroot] [PATCH 09/11 v2] package/owl-linux: " Yann E. MORIN
2015-06-11 23:13 ` Arnout Vandecappelle [this message]
2015-06-12 17:55 ` Yann E. MORIN
2015-06-12 23:19 ` Arnout Vandecappelle
2015-06-10 19:22 ` [Buildroot] [PATCH 10/11 v2] package/simicsfs: " Yann E. MORIN
2015-06-11 23:13 ` Arnout Vandecappelle
2015-06-10 19:22 ` [Buildroot] [PATCH 11/11 v2] package/sysdig: " Yann E. MORIN
2015-06-11 18:03 ` [Buildroot] [PATCH 0/11 v2] pkg-kernel-module: new infra to ease building kernel modules (branch yem/kernel-modules) Yann E. MORIN
2015-06-11 23:18 ` Arnout Vandecappelle
2015-06-12 17:47 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=557A1606.1030402@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox