Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [V2 3/4] A20-OLinuXino-Lime: new board (mainline)
Date: Mon, 22 Jun 2015 14:06:15 +0200	[thread overview]
Message-ID: <5587FA37.7020800@lucaceresoli.net> (raw)
In-Reply-To: <1434741204-3988-4-git-send-email-francois.perrad@gadz.org>

Dear Francois,

Francois Perrad wrote:
> config device tree / mainline (4.0.5)
>
> Signed-off-by: Francois Perrad <francois.perrad@gadz.org>
> ---
>   board/olimex/a20_olinuxino_lime/boot.cmd      |  5 ++
>   board/olimex/a20_olinuxino_lime/post-build.sh |  8 +++
>   board/olimex/a20_olinuxino_lime/readme.txt    | 86 +++++++++++++++++++++++++++
>   configs/olimex_a20_olinuxino_defconfig        | 41 +++++++++++++

To differentiate it from the Lime2 and the Micro, the defconfig should
be named configs/olimex_a20_olinuxino_lime_defconfig
                                      ^^^^^

It's not just a nitpick. I'm working on a -Micro these days and I will
probably send a defconfig for it. The -Micro must pull a different
U-Boot config, so the Buildroot defconfig will be different as well.

On the other hand, I _suspect_ the files in
boards/olimex/a20_olinuxino_lime can be generalized with minimal effort
to encompass both boards. But I cannot confirm that right now.

[...]

> diff --git a/board/olimex/a20_olinuxino_lime/readme.txt b/board/olimex/a20_olinuxino_lime/readme.txt
> new file mode 100644
> index 0000000..cc661a6
> --- /dev/null
> +++ b/board/olimex/a20_olinuxino_lime/readme.txt
> @@ -0,0 +1,86 @@
> +A20-OLinuXino-LIME
> +
> +Intro
> +=====
> +
> +This is a open hardware board,
> +see https://www.olimex.com/Products/OLinuXino/open-source-hardware

Why not a link to the board page itself as well?
It's https://www.olimex.com/Products/OLinuXino/A20/A20-OLinuXino-LIME/

I build-tested this patch, I should have a board in a few days and be
able to run-test it as well.

[Build test only]
Tested-by: Luca Ceresoli <luca@lucaceresoli.net>

-- 
Luca

  parent reply	other threads:[~2015-06-22 12:06 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-19 19:13 [Buildroot] [V2 0/4] A20-OLinuXino-Lime: new board Francois Perrad
2015-06-19 19:13 ` [Buildroot] [V2 1/4] sunxi-board: bump to version a6a4e94066f4ec6b26fc7060dc453a6bcf26a504 Francois Perrad
2015-06-21  4:42   ` Thomas Petazzoni
2015-06-19 19:13 ` [Buildroot] [V2 2/4] a10disp: bump to version v0.6.1 Francois Perrad
2015-06-21  4:43   ` Thomas Petazzoni
2015-06-19 19:13 ` [Buildroot] [V2 3/4] A20-OLinuXino-Lime: new board (mainline) Francois Perrad
2015-06-19 20:49   ` Arnout Vandecappelle
2015-06-22 12:23     ` Luca Ceresoli
2015-06-22 20:56       ` Yann E. MORIN
2015-06-22 21:22       ` Arnout Vandecappelle
2015-06-22 12:06   ` Luca Ceresoli [this message]
2015-06-19 19:13 ` [Buildroot] [V2 4/4] A20-OLinuXino-Lime: new board (mali) Francois Perrad
2015-06-19 20:08   ` Maxime Ripard
2015-06-20  5:28     ` François Perrad
2015-06-20  7:29       ` Maxime Ripard
2015-06-19 20:49   ` Arnout Vandecappelle
2015-06-20  5:39     ` François Perrad
2015-06-19 21:55   ` Arnout Vandecappelle
2015-06-20  5:33     ` François Perrad
2015-06-20  9:26       ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5587FA37.7020800@lucaceresoli.net \
    --to=luca@lucaceresoli.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox