From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] board/acmesystems/arietta: new board
Date: Mon, 29 Jun 2015 19:25:47 -0300 [thread overview]
Message-ID: <5591C5EB.2010700@zacarias.com.ar> (raw)
In-Reply-To: <1434537135-32177-1-git-send-email-angelo.compagnucci@gmail.com>
On 17/06/15 07:32, Angelo Compagnucci wrote:
> This patch adds support to the Arietta board from Acmesystems.
> This board comes in two memory sizes (128m and 256m) hence the
> reason for two different configs.
>
> Signed-off-by: Angelo Compagnucci <angelo.compagnucci@gmail.com>
Hi Angelo.
A few nits:
> board/acmesystems/arietta/linux-4.0.config | 99 ++++++++++++++++
Any particular reason you need a custom config instead of being able to
use at91_dt (like on the Aria sample i sent)?
I know the Arietta lacks an ethernet PHY, but the DTS should take care
of that.
> +BR2_TARGET_AT91BOOTSTRAP3_CUSTOM_REPO_VERSION="acme"
Also the "acme" tag seems to be the "master" of customization (i.e. a
moving target), could you switch to a commit hash?
Otherwise it looks OK without having hardware to test and you can have
my Acked-by if you address these concerns.
Thanks.
Regards.
next prev parent reply other threads:[~2015-06-29 22:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-06-17 10:32 [Buildroot] [PATCH] board/acmesystems/arietta: new board Angelo Compagnucci
2015-06-29 22:25 ` Gustavo Zacarias [this message]
2015-06-30 10:05 ` Angelo Compagnucci
2015-06-30 11:24 ` Gustavo Zacarias
2015-08-29 21:02 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5591C5EB.2010700@zacarias.com.ar \
--to=gustavo@zacarias.com.ar \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox