Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] linux: adjust fixup logic for ktap
Date: Sat, 11 Jul 2015 14:20:43 +0200	[thread overview]
Message-ID: <55A10A1B.3060800@mind.be> (raw)
In-Reply-To: <1424612340-2332-1-git-send-email-thomas.petazzoni@free-electrons.com>

On 02/22/15 14:39, Thomas Petazzoni wrote:
> The ktap package requires some parts of the kernel tracing
> infrastructure to be enabled, especially
> CONFIG_EVENT_TRACING. However, this option is a blind option in the
> kernel, so enabling it in linux.mk has no effect: we need to enable a
> non-blind option that selects CONFIG_EVENT_TRACING. We've chosen to
> select CONFIG_FTRACE.

 I think it makes more sense to select the smaller ENABLE_DEFAULT_TRACERS, no?

 Otherwise:
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>


 Regards,
 Arnout

> 
> This fixes the build of ktap.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  linux/linux.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/linux/linux.mk b/linux/linux.mk
> index 29f59e8..75f4936 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -198,7 +198,7 @@ define LINUX_CONFIGURE_CMDS
>  		$(call KCONFIG_ENABLE_OPT,CONFIG_INOTIFY_USER,$(@D)/.config))
>  	$(if $(BR2_PACKAGE_KTAP),
>  		$(call KCONFIG_ENABLE_OPT,CONFIG_DEBUG_FS,$(@D)/.config)
> -		$(call KCONFIG_ENABLE_OPT,CONFIG_EVENT_TRACING,$(@D)/.config)
> +		$(call KCONFIG_ENABLE_OPT,CONFIG_FTRACE,$(@D)/.config)
>  		$(call KCONFIG_ENABLE_OPT,CONFIG_PERF_EVENTS,$(@D)/.config)
>  		$(call KCONFIG_ENABLE_OPT,CONFIG_FUNCTION_TRACER,$(@D)/.config))
>  	$(if $(BR2_PACKAGE_SYSTEMD),
> 


-- 
Arnout Vandecappelle                          arnout at mind be
Senior Embedded Software Architect            +32-16-286500
Essensium/Mind                                http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium           BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint:  7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF

  reply	other threads:[~2015-07-11 12:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-02-22 13:39 [Buildroot] [PATCH] linux: adjust fixup logic for ktap Thomas Petazzoni
2015-07-11 12:20 ` Arnout Vandecappelle [this message]
2015-07-13 16:27 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A10A1B.3060800@mind.be \
    --to=arnout@mind.be \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox