From: Arnout Vandecappelle <arnout@mind.be>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] gptfdisk: bump version 1.0.0
Date: Mon, 13 Jul 2015 20:59:56 +0200 [thread overview]
Message-ID: <55A40AAC.2070903@mind.be> (raw)
In-Reply-To: <CAJup9cg-NUSxF_wCA-r7Uh9RQF6E+1ytWc0V1Z6Jf7GiMd56Pg@mail.gmail.com>
On 07/13/15 20:33, Aur?lien Chabot wrote:
>
> On Mon, Jul 13, 2015 at 8:26 PM, Aur?lien Chabot <aurelien@chabot.fr
> <mailto:aurelien@chabot.fr>> wrote:
>
> -+ $(CXX) $(LIB_OBJS) cgdisk.o gptcurses.o $(LDFLAGS) -luuid -lncursesw
> $(LDLIBS) -o cgdisk
> ++ $(CXX) $(LIB_OBJS) cgdisk.o gptcurses.o $(LDFLAGS) -luuid -lncurses
> $(LDLIBS) -o cgdisk
>
>
> I had to do that to make it build correctly. This seems strange to me, any idea
> why ?
It looks like gptfdisk no longer uses the wide-char version of ncurses. Or
perhaps it depends on the configuration...
In that case, the select of BR2_PACKAGE_NCURSES_WCHAR can probably be removed
as well. Could you test that?
Oh, and if you resubmit, please mention a change like this explicitly in the
commit log (along with an explanation why it is needed, which would have been
difficult in this case since you didn't understand :-).
Regards,
Arnout
--
Arnout Vandecappelle arnout at mind be
Senior Embedded Software Architect +32-16-286500
Essensium/Mind http://www.mind.be
G.Geenslaan 9, 3001 Leuven, Belgium BE 872 984 063 RPR Leuven
LinkedIn profile: http://www.linkedin.com/in/arnoutvandecappelle
GPG fingerprint: 7493 020B C7E3 8618 8DEC 222C 82EB F404 F9AC 0DDF
next prev parent reply other threads:[~2015-07-13 18:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-13 18:26 [Buildroot] [PATCH] gptfdisk: bump version 1.0.0 Aurélien Chabot
2015-07-13 18:33 ` Aurélien Chabot
2015-07-13 18:59 ` Arnout Vandecappelle [this message]
2015-07-17 22:30 ` [Buildroot] [PATCHv2] " Aurélien Chabot
2015-07-17 22:30 ` Aurélien Chabot
2015-07-18 9:29 ` Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55A40AAC.2070903@mind.be \
--to=arnout@mind.be \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox