Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Romain Naour <romain.naour@openwide.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/7] package/perf: if slang is enabled, depend on it
Date: Tue, 14 Jul 2015 17:45:38 +0200	[thread overview]
Message-ID: <55A52EA2.4020000@openwide.fr> (raw)
In-Reply-To: <1426714983-24803-1-git-send-email-steven@uplinklabs.net>

Hi Steven,

Le 18/03/2015 22:42, Steven Noonan a ?crit :
> Signed-off-by: Steven Noonan <steven@uplinklabs.net>
> ---
>  package/perf/perf.mk | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/perf/perf.mk b/package/perf/perf.mk
> index f6591a6..2b0702c 100644
> --- a/package/perf/perf.mk
> +++ b/package/perf/perf.mk
> @@ -34,6 +34,10 @@ ifeq ($(BR2_arc),y)
>  	PERF_MAKE_FLAGS += NO_BACKTRACE=1
>  endif
>  
> +ifeq ($(BR2_PACKAGE_SLANG),y)
> +	PERF_DEPENDENCIES += slang
> +endif
> +

The slang support can't be enabled simply by adding the slang package
dependency, because newt support is disabled in PERF_MAKE_FLAGS:

PERF_MAKE_FLAGS = NO_NEWT=1

In tools/perl/config/Makefile, the slang support is disabled here (kernel 4.2-rc2):

ifdef NO_NEWT
  NO_SLANG=1
endif

So, you need to enable newt before.

Can you rework this patch and resubmit ?

Best regards,
Romain Naour

>  ifeq ($(BR2_PACKAGE_ELFUTILS),y)
>  	PERF_DEPENDENCIES += elfutils
>  else
> 

  parent reply	other threads:[~2015-07-14 15:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-03-18 21:42 [Buildroot] [PATCH 1/7] package/perf: if slang is enabled, depend on it Steven Noonan
2015-03-18 21:42 ` [Buildroot] [PATCH 2/7] package/perf: if numactl (libnuma) " Steven Noonan
2015-03-18 21:42 ` [Buildroot] [PATCH 3/7] package/perf: if libunwind " Steven Noonan
2015-03-18 21:43 ` [Buildroot] [PATCH 4/7] package/perf: build outside kernel tree Steven Noonan
2015-03-19 23:21   ` Arnout Vandecappelle
2015-03-20  3:08     ` Steven Noonan
2015-03-18 21:43 ` [Buildroot] [PATCH 5/7] package/perf: patch installation paths Steven Noonan
2015-07-14 22:06   ` Romain Naour
2015-03-18 21:43 ` [Buildroot] [PATCH 6/7] package/perf: add patch to prevent crash on empty history buffer Steven Noonan
2015-03-18 21:43 ` [Buildroot] [PATCH 7/7] package/perf: use correct definition of ARCH on x86_64 Steven Noonan
2015-07-14 15:45 ` Romain Naour [this message]
2015-07-14 17:00   ` [Buildroot] [PATCH 1/7] package/perf: if slang is enabled, depend on it Romain Naour

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A52EA2.4020000@openwide.fr \
    --to=romain.naour@openwide.fr \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox