Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Zacarias <gustavo@zacarias.com.ar>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package: Fix overwrite inittab w/ default skeleton
Date: Thu, 16 Jul 2015 18:17:21 -0300	[thread overview]
Message-ID: <55A81F61.3050307@zacarias.com.ar> (raw)
In-Reply-To: <20150716230722.304e5f9a@free-electrons.com>

On 16/07/15 18:07, Thomas Petazzoni wrote:

> Unfortunately, even if Gustavo gave his Acked-by, I'm tempted to not
> apply this patch. There are *tons* of other stuff that we don't install
> conditionally. For example, we used to install init scripts only if an
> init script was not already installed to allow a custom skeleton to
> provide such init scripts. But a while ago, we decided to get rid of
> this policy, and install init scripts and configuration files
> unconditionally. Just a few commits related to that:

Actually i reported the bug to Maxime, he just forgot to add the 
Reported-By.
The problem with this is that it's a change in behaviour, this didn't 
happen in the previous releases.

> Our reasoning is that using a custom skeleton is highly discouraged,
> and people should instead use a rootfs overlay or a post-build script
> for their customization.
>
> I don't see why inittab should be handled differently.
>
> I'll mark your patch as Rejected for the time being. If there is some
> more arguments on why we should have a special handling of inittab,
> then we can rediscuss the patch of course.

My usage scenario is customized initscripts that rely on a very minimal 
inittab (rcS, rcK and getty, nothing more).
All of the basic startup is handled in initscripts, which i think we 
should do for BR as well - there's no reason to stick a lot of stuff in 
inittab IMO.
But even if we do that i'm still concerned about the behaviour change 
that can lead to non-working systems when upgrading buildroot.
Another option is to just get rid of the custom skeleton altogether, if 
it's being stepped on right and left what's the purpose?
Regards.

  reply	other threads:[~2015-07-16 21:17 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-16 16:30 [Buildroot] [PATCH] package: Fix overwrite inittab w/ default skeleton Maxime Hadjinlian
2015-07-16 16:38 ` Gustavo Zacarias
2015-07-16 21:07 ` Thomas Petazzoni
2015-07-16 21:17   ` Gustavo Zacarias [this message]
2015-07-16 21:35     ` Thomas Petazzoni
2015-07-16 21:42       ` Maxime Hadjinlian
2015-07-16 22:56         ` Arnout Vandecappelle
2015-07-16 21:48       ` Gustavo Zacarias

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A81F61.3050307@zacarias.com.ar \
    --to=gustavo@zacarias.com.ar \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox