Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Hollis Blanchard <hollis_blanchard@mentor.com>
To: buildroot@busybox.net
Subject: [Buildroot] [RFC/PATCH] linux: remove the zImage before rebuild
Date: Fri, 17 Jul 2015 09:01:32 -0700	[thread overview]
Message-ID: <55A926DC.9010803@mentor.com> (raw)
In-Reply-To: <1411773774-7712-1-git-send-email-guido@vanguardiasur.com.ar>

Hi Guido, I just ran across this discussion <http://patchwork.ozlabs.org/patch/394002/> in patchwork, and wanted to say I hit the same thing this week (and spent a few hours figuring out what had gone wrong). Has there been any activity on the problem recently?

Hollis Blanchard
Mentor Graphics Emulation Division

On 09/26/2014 04:22 PM, Guido Mart?nez wrote:
> Currently, if we run "make linux-rebuild", the device tree blob gets
> appended twice to the kernel image, rendering the latter append useless.
>
> Fix this by removing the zImage before building, so the DTB append runs
> on a fresh kernel image. This is not optimal as the final Linux linking
> step is run again, but at least we get sensible results.
>
> Signed-off-by: Guido Mart?nez <guido@vanguardiasur.com.ar>
> ---
> Hi guys,
>
> Has anyone ran into the above problem? It was a small headache for me,
> so I wrote this small patch.
>
> It's not great, the right thing to do would be copying the zImage out
> of the kernel tree and appending the DTB there, but my attempt at doing
> that broke some other builds. This should work every time.
>
>
>  linux/linux.mk | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/linux/linux.mk b/linux/linux.mk
> index 2fb7437..14c2b8e 100644
> --- a/linux/linux.mk
> +++ b/linux/linux.mk
> @@ -263,6 +263,10 @@ endif
>  # Compilation. We make sure the kernel gets rebuilt when the
>  # configuration has changed.
>  define LINUX_BUILD_CMDS
> +	# Remove the previous image, if it exists, to prevent appending
> +	# multiple DTBs
> +	rm -f $(KERNEL_ARCH_PATH)/boot/zImage
> +
>  	$(if $(BR2_LINUX_KERNEL_USE_CUSTOM_DTS),
>  		cp $(call qstrip,$(BR2_LINUX_KERNEL_CUSTOM_DTS_PATH)) $(KERNEL_ARCH_PATH)/boot/dts/)
>  	$(TARGET_MAKE_ENV) $(MAKE) $(LINUX_MAKE_FLAGS) -C $(@D) $(LINUX_TARGET_NAME)

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150717/de46db10/attachment.html>

  parent reply	other threads:[~2015-07-17 16:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-26 23:22 [Buildroot] [RFC/PATCH] linux: remove the zImage before rebuild Guido Martínez
2014-10-22 14:40 ` Guido Martínez
2015-03-08 17:47 ` Thomas Petazzoni
2015-03-08 18:53   ` Guido Martínez
2015-07-17 16:01 ` Hollis Blanchard [this message]
2015-07-17 16:34   ` Guido Martínez
2015-07-17 17:41     ` Thomas Petazzoni
2015-07-17 18:49       ` Hollis Blanchard
2015-07-17 21:16         ` Thomas Petazzoni
2015-07-17 21:24           ` Hollis Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55A926DC.9010803@mentor.com \
    --to=hollis_blanchard@mentor.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox