From: "Guillaume GARDET - Oliséo" <guillaume.gardet@oliseo.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH V2] c-icap: fix config script by adding $(STAGING_DIR) prefix to link path. It fixes c-icap-modules build.
Date: Fri, 24 Jul 2015 16:04:15 +0200 [thread overview]
Message-ID: <55B245DF.8020401@oliseo.fr> (raw)
In-Reply-To: <20150723231120.75b681e8@free-electrons.com>
Le 23/07/2015 23:11, Thomas Petazzoni a ?crit :
> Dear Guillaume GARDET,
>
> On Thu, 23 Jul 2015 10:45:47 +0200, Guillaume GARDET wrote:
>> Reported-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
>> Signed-off-by: Guillaume GARDET <guillaume.gardet@oliseo.fr>
>> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> I applied, but quite a few things were still wrong with the patch:
>
> * The commit title is too long. It should be less than 80 characters.
> The commit title should only be a summary of the commit log itself.
>
> * The commit title is wrong: you're no longer adding $(STAGING_DIR) to
> the link path
>
> * The commit log was missing a reference to the autobuilder failure
> that this patch is fixing.
>
> I've fixed those problems and applied. See:
>
> http://git.buildroot.net/buildroot/commit/?id=6c73215493335f1ede26cad2d3898ef543d871d6
Thanks.
I copy/paste V1 to V2 too quickly. Sorry.
Guillaume
>
> Thanks,
>
> Thomas
prev parent reply other threads:[~2015-07-24 14:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-22 12:40 [Buildroot] [PATCH] c-icap: fix config script by adding $(STAGING_DIR) prefix to link path. It fixes c-icap-modules build Guillaume GARDET
2015-07-22 12:55 ` Thomas Petazzoni
2015-07-22 13:30 ` Guillaume GARDET - Oliséo
2015-07-22 13:51 ` Thomas Petazzoni
2015-07-23 8:45 ` [Buildroot] [PATCH V2] " Guillaume GARDET
2015-07-23 21:11 ` Thomas Petazzoni
2015-07-24 14:04 ` Guillaume GARDET - Oliséo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B245DF.8020401@oliseo.fr \
--to=guillaume.gardet@oliseo.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox