Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Ceresoli <luca@lucaceresoli.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] rtl8188eu: new package
Date: Tue, 28 Jul 2015 09:31:32 +0200	[thread overview]
Message-ID: <55B72FD4.1030704@lucaceresoli.net> (raw)
In-Reply-To: <20150727234308.77aff941@free-electrons.com>

Dear Thomas,

thanks for the cleanups. I have a question, see below.

Thomas Petazzoni wrote:
> Dear Luca Ceresoli,
>
> On Mon, 27 Jul 2015 12:06:20 +0200, Luca Ceresoli wrote:
>> Signed-off-by: Luca Ceresoli <luca@lucaceresoli.net>
>> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
>>
>> ---
>
> I've applied, but there were still numerous improvements that could be
> made after the conversion to the kernel-module infra:
>
>      [Thomas:
>        - remove patches 0001 and 0002, they are not needed since when using
>          the kernel-module infrastructure, we directly call the kernel
>          build system and bypass the one provided by the external module
>        - install the firmware directly in the Buildroot .mk file, which
>          allows to also remove patch 0003.

I'm OK with this change: better avoiding patches when possible.

But should patch 3 be merged upstream at some point, I think it would
be better to revert to my original RTL8188EU_INSTALL_FIRMWARE hook.
It should continue working of the firmware were moved around the
package directory hierarchy, and it's even one line shorter (!).

Do you agree?

-- 
Luca

  reply	other threads:[~2015-07-28  7:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-27 10:06 [Buildroot] [PATCH v3] rtl8188eu: new package Luca Ceresoli
2015-07-27 21:43 ` Thomas Petazzoni
2015-07-28  7:31   ` Luca Ceresoli [this message]
2015-07-28  7:35     ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B72FD4.1030704@lucaceresoli.net \
    --to=luca@lucaceresoli.net \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox