Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Floris Bos <bos@je-eigen-domein.nl>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1 2/3] aufs: new kernel extension.
Date: Tue, 04 Aug 2015 00:22:35 +0200	[thread overview]
Message-ID: <55BFE9AB.4050908@je-eigen-domein.nl> (raw)
In-Reply-To: <CA+h8R2pFkwsu+1dN=W_kjPHQq8du5MhaHjCNoP2D=K8ZMEvkug@mail.gmail.com>

On 08/03/2015 11:23 PM, Christian Stewart wrote:
> Hi Yann,
>
>     Remove this 'depends on' but enclose the options inside an if...endif
>     block.
>
>
> Done here:
>
> https://github.com/paralin/buildroot/commit/8dd9e882fac4a4512d9dcad8fe19da02ff901e45 
>
>
>     > +     default BR2_PACKAGE_AUFS_4X if BR2_KERNEL_HEADERS_4_0 ||
>     BR2_KERNEL_HEADERS_4.1
>     > +     default BR2_PACKAGE_AUFS_3X if !(BR2_KERNEL_HEADERS_4_0 ||
>     BR2_KERNEL_HEADERS_4.1)
>
>     See the comment below, about kernel version...
>
>
> As you caught in your next email, these are *defaults*, or guesses. 
> The user should still verify if the version is correct. The guess is 
> correct a lot of the time and is helpful to the user because the aufs 
> branches are often not obviously named.

Problem is that the guess made may appear correct to the user, while it 
is not.

Oh, I'm using Linux 3.18.19, and buildroot selected "aufs3.18", that 
looks ok.
While he may need "aufs3.18.1+" instead.

By forcing the user to enter it manually, he would at least have to 
figure out what branches are available.



Yours sincerely,

Floris Bos

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20150804/c7b819cf/attachment.html>

  reply	other threads:[~2015-08-03 22:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-31 23:56 [Buildroot] [PATCH v1 1/3] aufs-standalone: new package Christian Stewart
2015-07-31 23:56 ` [Buildroot] [PATCH v1 2/3] aufs: new kernel extension Christian Stewart
2015-08-03 21:13   ` Yann E. MORIN
2015-08-03 21:16     ` Yann E. MORIN
2015-08-03 21:23     ` Christian Stewart
2015-08-03 22:22       ` Floris Bos [this message]
2015-07-31 23:56 ` [Buildroot] [PATCH v1 3/3] aufs-util: new package Christian Stewart
2015-08-03 20:41 ` [Buildroot] [PATCH v1 1/3] aufs-standalone: " Yann E. MORIN
2015-08-03 20:59   ` Christian Stewart
2015-12-01 22:05 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55BFE9AB.4050908@je-eigen-domein.nl \
    --to=bos@je-eigen-domein.nl \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox